New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume qunit is the default test framework #127

Merged
merged 1 commit into from Aug 12, 2015

Conversation

Projects
None yet
2 participants
@TehShrike
Contributor

TehShrike commented Aug 8, 2015

I'm testing using tape, and am calling BrowserStack.post myself.

I am not supplying in any string for the test_framework property in browserstack.json.

When the qunit patch is included, errors occur in the console log.

This patch fixes the error, so that qunit code is only injected if the users actually ask for it.

@shirish87

This comment has been minimized.

Contributor

shirish87 commented Aug 8, 2015

Sounds reasonable. 👍
Thanks.

@TehShrike

This comment has been minimized.

Contributor

TehShrike commented Aug 11, 2015

Any chance this could get deployed to npm soon? I'd like to be able to use browserstack-runner on travis without having to commit a custom version to all my repos or deploy a fork to npm. <3

shirish87 added a commit that referenced this pull request Aug 12, 2015

Merge pull request #127 from TehShrike/allow-other-test-types
Don't assume qunit is the default test framework

@shirish87 shirish87 merged commit 151674d into browserstack:master Aug 12, 2015

@TehShrike

This comment has been minimized.

Contributor

TehShrike commented Aug 14, 2015

Published as browserstack-runner-tehshrike 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment