From a171c93ad1171c3ad4070fb02b0b9e159f98eab5 Mon Sep 17 00:00:00 2001 From: tech-sushant Date: Fri, 24 Oct 2025 18:14:46 +0530 Subject: [PATCH 1/3] fix: command syntax for opening browser on Windows --- src/tools/live-utils/start-session.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/live-utils/start-session.ts b/src/tools/live-utils/start-session.ts index 04960fa5..2a8ac902 100644 --- a/src/tools/live-utils/start-session.ts +++ b/src/tools/live-utils/start-session.ts @@ -133,7 +133,7 @@ function openBrowser(launchUrl: string): void { process.platform === "darwin" ? ["open", launchUrl] : process.platform === "win32" - ? ["cmd", "/c", "start", launchUrl] + ? ["cmd", "/c", "start", `""`, `"${launchUrl}"`] : ["xdg-open", launchUrl]; // nosemgrep:javascript.lang.security.detect-child-process.detect-child-process From 1beb821d95c18630ae39dd915041d168f4d63ba9 Mon Sep 17 00:00:00 2001 From: tech-sushant Date: Tue, 28 Oct 2025 01:15:20 +0530 Subject: [PATCH 2/3] fix: conditionally add 'start' parameter in URL building functions --- src/tools/live-utils/start-session.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/live-utils/start-session.ts b/src/tools/live-utils/start-session.ts index 2a8ac902..65919340 100644 --- a/src/tools/live-utils/start-session.ts +++ b/src/tools/live-utils/start-session.ts @@ -94,7 +94,7 @@ function buildDesktopUrl( resolution: "responsive-mode", speed: "1", local: isLocal ? "true" : "false", - start: "true", + ...(isLocal ? {} : { start: "true" }), }); return `https://live.browserstack.com/dashboard#${params.toString()}`; } @@ -120,7 +120,7 @@ function buildMobileUrl( scale_to_fit: "true", speed: "1", local: isLocal ? "true" : "false", - start: "true", + ...(isLocal ? {} : { start: "true" }), }); return `https://live.browserstack.com/dashboard#${params.toString()}`; } From d910a146b92956e55147676928a26e9078465bab Mon Sep 17 00:00:00 2001 From: tech-sushant Date: Tue, 28 Oct 2025 11:45:09 +0530 Subject: [PATCH 3/3] fix: add shell option for opening browser on Windows --- src/tools/live-utils/start-session.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tools/live-utils/start-session.ts b/src/tools/live-utils/start-session.ts index 65919340..2fc8500d 100644 --- a/src/tools/live-utils/start-session.ts +++ b/src/tools/live-utils/start-session.ts @@ -140,6 +140,7 @@ function openBrowser(launchUrl: string): void { const child = childProcess.spawn(command[0], command.slice(1), { stdio: "ignore", detached: true, + ...(process.platform === "win32" ? { shell: true } : {}), }); child.on("error", (err) => logger.error(`Failed to open browser: ${err}. URL: ${launchUrl}`),