Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Conversation

@valfirst
Copy link
Contributor

No description provided.

@valfirst valfirst force-pushed the add-ability-to-create-selenium-proxy-from-hostname-and-port branch from a399f47 to 3ee00e0 Compare November 20, 2020 09:20
@ericbeland
Copy link
Contributor

Hi @valfirst, I haven't had a chance to look at this yet, but could you add some background on your use case and needs into the PR for when we review? Any context is helpful. Best,

Eric

@valfirst
Copy link
Contributor Author

valfirst commented Dec 3, 2020

Hi @ericbeland, we have Docker-based environment (containers with browsers), so we can't use InetSocketAddress to configure Selenium proxy, because the address like host.docker.internal is reachable only from containers. Having the changes from PR we can use simple String to configure the host.

For now we are forced to create Selenium proxy in the ugly way:

https://github.com/vividus-framework/vividus/blob/88df73eefb32b78fab6bd3e736eddbb3b114b5d4/vividus-extension-selenium/src/main/java/org/vividus/proxy/Proxy.java#L116-L131

@ericbeland ericbeland merged commit d0cdd76 into browserup:master Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants