Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `which` command as per request #36. #84

Merged
merged 2 commits into from Aug 5, 2015

Conversation

Projects
None yet
3 participants
@shaleh
Copy link

shaleh commented Aug 4, 2015

As the subject says, add support for multirust which cmd as per #36.

@brson

This comment has been minimized.

Copy link
Owner

brson commented Aug 4, 2015

Thanks! Looks good except for the notes.

brson added a commit that referenced this pull request Aug 5, 2015

Merge pull request #84 from shaleh/features/add-which-command
Add support for `which` command as per request #36.

@brson brson merged commit 9e111c5 into brson:master Aug 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brson

This comment has been minimized.

Copy link
Owner

brson commented Aug 5, 2015

Thanks again.

@shaleh shaleh deleted the shaleh:features/add-which-command branch Aug 5, 2015

@tamird

This comment has been minimized.

Copy link
Contributor

tamird commented Aug 7, 2015

@brson perhaps the error handling is needed after all; running multirust which without an argument results in a puzzling error message /usr/local/bin/multirust: line 1288: $1: unbound variable

@brson

This comment has been minimized.

Copy link
Owner

brson commented Aug 7, 2015

@tamird oh, hm, thanks for verifying. I expected the input to be sanitized elsewhere, probably during argument parsing, and thought that check was defensive. Do you mind putting that check in handle_command_line_args? There are some existing argument checks there to crib off of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.