Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for `which` command as per request #36. #84
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks! Looks good except for the notes. |
brson
added a commit
that referenced
this pull request
Aug 5, 2015
brson
merged commit 9e111c5
into
brson:master
Aug 5, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks again. |
shaleh
deleted the
shaleh:features/add-which-command
branch
Aug 5, 2015
This comment has been minimized.
This comment has been minimized.
|
@brson perhaps the error handling is needed after all; running |
This comment has been minimized.
This comment has been minimized.
|
@tamird oh, hm, thanks for verifying. I expected the input to be sanitized elsewhere, probably during argument parsing, and thought that check was defensive. Do you mind putting that check in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
shaleh commentedAug 4, 2015
As the subject says, add support for
multirust which cmdas per #36.