Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality: break apart the main "pmap" method #3

Closed
bruceadams opened this issue Dec 19, 2012 · 1 comment
Closed

Improve code quality: break apart the main "pmap" method #3

bruceadams opened this issue Dec 19, 2012 · 1 comment

Comments

@bruceadams
Copy link
Owner

Running Code Climate on this code reminds me of things I don't like. One concern is: the main "pmap" method is too complex.

@shepmaster has two commits addressing this very nicely.
shepmaster@1f3ed2a
shepmaster@65d0e55
@davidbiehl davidbiehl mentioned this issue Nov 7, 2015
Merged
bruceadams added a commit that referenced this issue Nov 8, 2015
@bruceadams
Merge pull request #12 from davidbiehl/thread_pool
dbd2ba3 
Refactor with peach_with_index and a ThreadPool

This closes issues #2, #3 and #4. Yay!
@bruceadams
Copy link
Owner Author

Fixed by #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bruceadams