New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--graphicsmap option isn't validated #893

Closed
bfirsh opened this Issue Nov 30, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@bfirsh
Contributor

bfirsh commented Nov 30, 2017

The documentation implies that you can provide --graphicsmap as a space separated list of formats, but this isn't the case. I originally tried:

--graphicsmap="svg png gif jpg jpeg eps.png ps.png ai.png pdf.png"

But this just failed to convert any images, until I realised they have to be provided as separate arguments.

A few things:

  1. Docs should be clearer, with an example of usage
  2. latexmlpost should throw fatal error if options are invalid
  3. Perhaps support this space-separated usage. It's much neater, and makes it clearer that you're overriding the default options with a new complete set of options. (I had to read the docs very carefully to realise that providing a single option overrode all the defaults, which is not the behaviour I expected.)

(I'll probably have a go at fixing this, but filing it here in case I don't get round to it!)

@brucemiller

This comment has been minimized.

Owner

brucemiller commented Dec 1, 2017

I was just trying to be concise, but I can see how it could be misinterpreted; I've clarified the doc. I also made it give an error when there are extra unrecognized arguments/options, which would have been the case here (everything after the svg were seen as extra arguments). Thanks for the report!

@brucemiller brucemiller closed this Dec 1, 2017

@bfirsh

This comment has been minimized.

Contributor

bfirsh commented Dec 1, 2017

Nice thanks!

@dginev dginev added this to the LaTeXML-0.8.3 milestone Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment