New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[binding-request] subcaption.sty #943

Closed
matteosecli opened this Issue Feb 4, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@matteosecli
Contributor

matteosecli commented Feb 4, 2018

I currently disable the package and redefine

\renewenvironment{subfigure}[2][#1]{\begin{figure}}{\end{figure}}

which avoids the errors. However, the figure numbering and the \textwidth inside the subfigure are not correct.

@dginev

This comment has been minimized.

Collaborator

dginev commented Feb 4, 2018

Is this a bug with the existing subfigure.sty.ltxml binding?

@dginev dginev added this to the LaTeXML-0.8.3 milestone Feb 4, 2018

@matteosecli

This comment has been minimized.

Contributor

matteosecli commented Feb 4, 2018

@dginev I'm sorry, my fault. The subfigure environment comes with the package subcaption, not from subfigure (indeed, they are incompatible). I changed the title accordingly.

@matteosecli matteosecli changed the title from [binding-request] subfigure.sty to [binding-request] subcaption.sty Feb 4, 2018

@dginev

This comment has been minimized.

Collaborator

dginev commented Feb 4, 2018

Cool, thanks for clarifying!

P.S. Mislicked and closed by accident, sorry!

@dginev dginev closed this Feb 4, 2018

@dginev dginev reopened this Feb 4, 2018

@dginev dginev modified the milestones: LaTeXML-0.8.3, LaTeXML-0.8.4 Feb 27, 2018

@dginev dginev referenced this issue Mar 1, 2018

Closed

Implement subcaption package #245

0 of 3 tasks complete
@brucemiller

This comment has been minimized.

Owner

brucemiller commented Apr 9, 2018

I've just checked in a fairly preliminary version of subcaption. it's missing all the styling, but I'll come back to that later. I'm going to go ahead & close, but if the lack of styling or other errors arise, please open a new issue (or reopen). Thanks!

@brucemiller brucemiller closed this Apr 9, 2018

@dginev dginev modified the milestones: LaTeXML-0.8.4, LaTeXML-0.8.3 Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment