New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent citation regressions #959

Closed
bfirsh opened this Issue Mar 14, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@bfirsh
Contributor

bfirsh commented Mar 14, 2018

Sometime in e14e9f0..d18cdad we're seeing some regressions for \cite.

The files are missing \documentclass{article}, but I'm seeing the same problem with that added at the top.

(Ref arxiv-vanity/engrafo#292)

@dginev dginev added this to the LaTeXML-0.8.3 milestone Mar 14, 2018

@dginev

This comment has been minimized.

Collaborator

dginev commented Mar 14, 2018

Thanks for the report! Since this could well be executable-specific, could you let me know the exact commands you ran to reproduce?

Can reproduce, taking a look

@dginev

This comment has been minimized.

Collaborator

dginev commented Mar 14, 2018

@brucemiller looks like switching from #refnum to #frefnum broke conversions that have a .bbl file?

change at:

c768661#diff-73d02df95f8342da0c0bc9a260d230d7R2906

The bbl content in question for this example is:

\begin{thebibliography}{28}
\bibitem[{Bloggs and Jones(2014)}]{bloggs2014}
Joe Bloggs and Phil Jones. 2014.
\newblock Compositional morphology for word representations and language modelling.
\newblock In \emph{Proceedings of ICML}.

\bibitem[{Cotterell and Sch{\"u}tze(2015)}]{cotterell2015morphological}
Ryan Cotterell and Hinrich Sch{\"u}tze. 2015.
\newblock Morphological word-embeddings.
\newblock In \emph{Proceedings of HLT-NAACL}.

\bibitem[{Foo and Bar(2020)}]{foobar2020}
Foo and Bar. 2020.
\newblock Just a title, not a source.
\end{thebibliography}

The generated intermediate XML has empty elements for refnum, here are the relevant snippets:

<cite class="ltx_citemacro_cite">[<bibref bibrefs="bloggs2014" separator="," show="Refnum" yyseparator=","/>]</cite>

and the bibitem:

      <bibitem key="bloggs2014" xml:id="bib.bibx1">
        <bibtag role="refnum"/>
        ...
@brucemiller

This comment has been minimized.

Owner

brucemiller commented Mar 14, 2018

Hmm... surprised any of this stuff got out already, but big set of patches coming soon which should fix this again.

@dginev

This comment has been minimized.

Collaborator

dginev commented Mar 15, 2018

"surprised any of this stuff got out already"

This is what happens when people use latexml in production :> Maybe we should up our test coverage?

@bfirsh

This comment has been minimized.

Contributor

bfirsh commented Mar 15, 2018

Awesome, thanks!

One of my current projects is producing a set of tex files that cover as much functionality as I can find. It’ll then compares the HTML output with known good HTML as an integration test. Happy to work together on that, if you’d like.

@brucemiller

This comment has been minimized.

Owner

brucemiller commented Apr 7, 2018

The 2 links above gave 404's, so maybe the arrangement of test cases has changed. I have checked the bbl that @dginev posted and this should be fixed now. Thanks for the report & test cases!

@brucemiller brucemiller closed this Apr 7, 2018

@bfirsh

This comment has been minimized.

Contributor

bfirsh commented Apr 7, 2018

Oops yes sorry should have sent absolute github URLs. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment