Skip to content

fixes typo in LaTeXML::Core::Token documentation - #796

Merged
brucemiller merged 1 commit into
brucemiller:masterfrom
teepeemm:fix_Token.pm_doc_typo
Nov 14, 2016
Merged

fixes typo in LaTeXML::Core::Token documentation#796
brucemiller merged 1 commit into
brucemiller:masterfrom
teepeemm:fix_Token.pm_doc_typo

Conversation

@teepeemm

@teepeemm teepeemm commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

This fixes the typo at the bottom of http://dlmf.nist.gov/LaTeXML/manual/coremodules/LaTeXML_Core_Token.html
in the description of getCSName

@teepeemm teepeemm changed the title fixes typo LaTeXML::Core::Token documentation fixes typo in LaTeXML::Core::Token documentation Sep 2, 2016
@teepeemm

teepeemm commented Sep 2, 2016

Copy link
Copy Markdown
Contributor Author

I have ln -s ../../tools/pre-commit .git/hooks setup. Does that automatically happen before a commit? Or do I need to invoke it manually? Does it matter if I'm committing from NetBeans?

Is it possible to do whatever Travis-Ci does before I commit? Or is that basically a quick make to ensure I've not done anything boneheaded? Or is Travis-Ci the same as pre-commit?

@teepeemm

teepeemm commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

Although looking more closely, it appears getCSName returns the PRIMITIVE_NAME by default, so that T_BEGIN->getCSName is actually "Begin". So I may have fixed a typo in the coding, but not the documentation.

@brucemiller

Copy link
Copy Markdown
Owner

Yes, you're right: it returns "Begin" 'cause that's what TeX does, so my POD markup and the doc itself was messed up.

Aside: the git hook just checks the formatting (and complains if it doesn't like it), but doesn't actually reformat. tools/latexmllint will reformat it for you, if you want. (But none of this will likely come into play in this case)

@brucemiller
brucemiller merged commit 7cfa1d2 into brucemiller:master Nov 14, 2016
@brucemiller

Copy link
Copy Markdown
Owner

I guess I forgot to pull this.... Thanks!

@teepeemm
teepeemm deleted the fix_Token.pm_doc_typo branch March 25, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants