New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes typo in LaTeXML::Core::Token documentation #796

Merged
merged 1 commit into from Nov 14, 2016

Conversation

Projects
None yet
2 participants
@teepeemm
Contributor

teepeemm commented Sep 1, 2016

This fixes the typo at the bottom of http://dlmf.nist.gov/LaTeXML/manual/coremodules/LaTeXML_Core_Token.html
in the description of getCSName

@teepeemm teepeemm changed the title from fixes typo LaTeXML::Core::Token documentation to fixes typo in LaTeXML::Core::Token documentation Sep 2, 2016

@teepeemm

This comment has been minimized.

Contributor

teepeemm commented Sep 2, 2016

I have ln -s ../../tools/pre-commit .git/hooks setup. Does that automatically happen before a commit? Or do I need to invoke it manually? Does it matter if I'm committing from NetBeans?

Is it possible to do whatever Travis-Ci does before I commit? Or is that basically a quick make to ensure I've not done anything boneheaded? Or is Travis-Ci the same as pre-commit?

@teepeemm

This comment has been minimized.

Contributor

teepeemm commented Sep 6, 2016

Although looking more closely, it appears getCSName returns the PRIMITIVE_NAME by default, so that T_BEGIN->getCSName is actually "Begin". So I may have fixed a typo in the coding, but not the documentation.

@brucemiller

This comment has been minimized.

Owner

brucemiller commented Sep 6, 2016

Yes, you're right: it returns "Begin" 'cause that's what TeX does, so my POD markup and the doc itself was messed up.

Aside: the git hook just checks the formatting (and complains if it doesn't like it), but doesn't actually reformat. tools/latexmllint will reformat it for you, if you want. (But none of this will likely come into play in this case)

@brucemiller brucemiller merged commit 7cfa1d2 into brucemiller:master Nov 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brucemiller

This comment has been minimized.

Owner

brucemiller commented Nov 14, 2016

I guess I forgot to pull this.... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment