Fix bug with wrongly checking all files inside archive input#814
Merged
brucemiller merged 1 commit intoNov 14, 2016
Merged
Conversation
Owner
|
makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an embarrassing oversight on my part - i had swapped the places of the grep/map pair, grepping on perl objects, instead of the file name held by them.
That lead to archives with no TeX file from the arXiv corpus to be falsely searched through, and in fact often
.clsand.styfiles were being converted in the absence of a real source, due to this error.An example directory tree I just tested with looks like:
As the authors used an encrypted
.cryfile, this archive contains no usable tex source and should be marked invalid by latexml. Which was the intention all along, and is indeed what happens with the patch here. But with the current master, converting the archive holding these files identifiesllncs.clsas the main TeX file and tries to convert it, failing with a Fatal.I'd appreciate a quick merge, would be happy to rerun the unexpected Fatals, which look to be largely due to this oversight. There may be other harder to detect cases of this, but they'll come to light in further reruns.