Skip to content

Add TexLive to Travis Tests - #852

Merged
brucemiller merged 1 commit into
brucemiller:masterfrom
tkw1536:better-travis
Jul 14, 2017
Merged

Add TexLive to Travis Tests#852
brucemiller merged 1 commit into
brucemiller:masterfrom
tkw1536:better-travis

Conversation

@tkw1536

@tkw1536 tkw1536 commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

This PR updates the Travis tests to run both with and without TexLive installed.

This commit updates the travis tests to run both with and without TexLive
installed.
@dginev

dginev commented Jul 13, 2017

Copy link
Copy Markdown
Collaborator

Don't you need a matrix or some such in the yml file? It would be awesome if we can travis-test both the with and without setups, that's really great! I just don't want us to use the no-texlive successes.

Really cool idea!

@tkw1536

tkw1536 commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

Don't you need a matrix or some such in the yml file? It would be awesome if we can travis-test both the with and without setups, that's really great!

This already makes a matrix. From the travis documentation:

For Perl projects, env and perl can be given as arrays to construct a build matrix.

You can have a look at the Travis Test for this PR, there are 2*4=8 test cases, for each perl version there is one with TEX=none and one with TEX=texlive

I just don't want us to use the no-texlive successes.

In order for the build to count as passing, all subtests have to pass. That means both with and without texlive, for each given perl version the tests have to succeed.

@dginev

dginev commented Jul 13, 2017

Copy link
Copy Markdown
Collaborator

Super cool! I'm two thumbs up for this then, great upgrade

@dginev

dginev commented Jul 13, 2017

Copy link
Copy Markdown
Collaborator

Btw I would also be for dropping the 5.18 version and adding the latest perl version supported by Travis instead, so that we stay compliant with the latest Perl. My ubuntu has 5.24 wondering if Travis has that too?

@tkw1536

tkw1536 commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

Travis should have that one too. According to their documentation they use perlbrew which goes up 5.26 I believe.

@tkw1536

tkw1536 commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

I would update the PR, but I am not sure why the exact versions that are currently tested have been choosen, so I will leave it to you to change travis.yml (allow edits from maintainers is on).

@brucemiller

Copy link
Copy Markdown
Owner

Too bad they don't have a way to specify all perls back to 5.10 (say). I'd certainly like to test against the newest perls! I don't recall who wrote the original travis.yml, but I'd forgotten about its existence until I needed to disable 5.10 for some XS testing. But since this patch does (at least) double duty, I wonder if we should prune some of the middle versions? 5.14, 5.20, 5.24 or something? I'd hate to overstay my welcome with travis :>

@brucemiller
brucemiller merged commit 3a85964 into brucemiller:master Jul 14, 2017
@tkw1536
tkw1536 deleted the better-travis branch July 14, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants