New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TexLive to Travis Tests #852

Merged
merged 1 commit into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@tkw1536
Contributor

tkw1536 commented Jul 13, 2017

This PR updates the Travis tests to run both with and without TexLive installed.

Add TexLive to Travis Tests
This commit updates the travis tests to run both with and without TexLive
installed.
@dginev

This comment has been minimized.

Collaborator

dginev commented Jul 13, 2017

Don't you need a matrix or some such in the yml file? It would be awesome if we can travis-test both the with and without setups, that's really great! I just don't want us to use the no-texlive successes.

Really cool idea!

@tkw1536

This comment has been minimized.

Contributor

tkw1536 commented Jul 13, 2017

Don't you need a matrix or some such in the yml file? It would be awesome if we can travis-test both the with and without setups, that's really great!

This already makes a matrix. From the travis documentation:

For Perl projects, env and perl can be given as arrays to construct a build matrix.

You can have a look at the Travis Test for this PR, there are 2*4=8 test cases, for each perl version there is one with TEX=none and one with TEX=texlive

I just don't want us to use the no-texlive successes.

In order for the build to count as passing, all subtests have to pass. That means both with and without texlive, for each given perl version the tests have to succeed.

@dginev

This comment has been minimized.

Collaborator

dginev commented Jul 13, 2017

Super cool! I'm two thumbs up for this then, great upgrade

@dginev

This comment has been minimized.

Collaborator

dginev commented Jul 13, 2017

Btw I would also be for dropping the 5.18 version and adding the latest perl version supported by Travis instead, so that we stay compliant with the latest Perl. My ubuntu has 5.24 wondering if Travis has that too?

@tkw1536

This comment has been minimized.

Contributor

tkw1536 commented Jul 13, 2017

Travis should have that one too. According to their documentation they use perlbrew which goes up 5.26 I believe.

@tkw1536

This comment has been minimized.

Contributor

tkw1536 commented Jul 13, 2017

I would update the PR, but I am not sure why the exact versions that are currently tested have been choosen, so I will leave it to you to change travis.yml (allow edits from maintainers is on).

@brucemiller

This comment has been minimized.

Owner

brucemiller commented Jul 14, 2017

Too bad they don't have a way to specify all perls back to 5.10 (say). I'd certainly like to test against the newest perls! I don't recall who wrote the original travis.yml, but I'd forgotten about its existence until I needed to disable 5.10 for some XS testing. But since this patch does (at least) double duty, I wonder if we should prune some of the middle versions? 5.14, 5.20, 5.24 or something? I'd hate to overstay my welcome with travis :>

@brucemiller brucemiller merged commit 3a85964 into brucemiller:master Jul 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tkw1536 tkw1536 deleted the tkw1536:better-travis branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment