Repository navigation
Set @filelist macro before reading file (fixes #857) - #858
Merged
Merged
Conversation
When loading a file through `InputDefinitions`, the @FileList macro was only set after the file has finished loading. This results in the macro being empty during the processing of a file. This commit fixes the issue by setting the @FileList macro before loading of the file. Furthermore, it adds a testcase to prevent this bug from reappearing in the future.
Contributor
Author
|
/cc @brucemiller As I mentioned to you offline, I have had some issues with implementing |
Owner
|
Looks good, but you forgot to add your test case files to the MANIFEST |
Owner
|
DOH!!! It's the first file in the commit !?!?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a file through
InputDefinitions, the@filelistmacro wasonly set after the file has finished loading (see #857). This results in the macro
being empty during the processing of a file.
This commit fixes the issue by setting the
@filelistmacro beforeloading of the file. Furthermore, it adds a testcase to prevent this bug
from reappearing in the future.