New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set @filelist macro before reading file (fixes #857) #858

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@tkw1536
Contributor

tkw1536 commented Aug 2, 2017

When loading a file through InputDefinitions, the @filelist macro was
only set after the file has finished loading (see #857). This results in the macro
being empty during the processing of a file.

This commit fixes the issue by setting the @filelist macro before
loading of the file. Furthermore, it adds a testcase to prevent this bug
from reappearing in the future.

Set @FileList macro before reading file (fixes #857)
When loading a file through `InputDefinitions`, the @FileList macro was
only set after the file has finished loading. This results in the macro
being empty during the processing of a file.

This commit fixes the issue by setting the @FileList macro before
loading of the file. Furthermore, it adds a testcase to prevent this bug
from reappearing in the future.
@tkw1536

This comment has been minimized.

Contributor

tkw1536 commented Aug 2, 2017

/cc @brucemiller As I mentioned to you offline, I have had some issues with implementing \ProcessOptionsX* for class files. I have basically tracked it down to this.

@brucemiller

This comment has been minimized.

Owner

brucemiller commented Aug 3, 2017

Looks good, but you forgot to add your test case files to the MANIFEST

@brucemiller

This comment has been minimized.

Owner

brucemiller commented Aug 3, 2017

DOH!!! It's the first file in the commit !?!?!

@brucemiller brucemiller merged commit c5d7566 into brucemiller:master Aug 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tkw1536 tkw1536 deleted the tkw1536:filelist-fix branch Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment