Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRewrite tools/makemanifest in Perl #859
Conversation
brucemiller
merged commit c841e72
into
brucemiller:master
Aug 8, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
tkw1536
deleted the
tkw1536:makemanifest-improvements
branch
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tkw1536 commentedAug 4, 2017
Previously, the tools/makemanifest script was written in bash. This had the problem, that the
sortcommand was behaving different on certain Linux installations, leading to inconsistent results.This PR rewrites the tool in pure perl, thus ensuring consistency between different systems. Furthermore, it adds three new switches to it, --quiet, --save and --diff. These can be used to suppress output, automatically overwrite the old MANIFEST file, and show a diff instead of the full new MANIFEST respectively.