Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite tools/makemanifest in Perl #859

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

tkw1536
Copy link
Contributor

@tkw1536 tkw1536 commented Aug 4, 2017

Previously, the tools/makemanifest script was written in bash. This had the problem, that the sort command was behaving different on certain Linux installations, leading to inconsistent results.

This PR rewrites the tool in pure perl, thus ensuring consistency between different systems. Furthermore, it adds three new switches to it, --quiet, --save and --diff. These can be used to suppress output, automatically overwrite the old MANIFEST file, and show a diff instead of the full new MANIFEST respectively.

Previously, the tools/makemanifest script was written in bash. This had
the problem, that the `sort' command was behaving different on certain
Linux installations, leading to inconsistent results.

This commit rewrites the tool in pure perl, thus ensuring consistency
between different systems. Furthermore, this commit adds three new
switches to it, --quiet, --save and --diff. These can be used to
suppress output, automatically overwrite the old MANIFEST file, and show
a diff instead of the full new MANIFEST respectively.
@brucemiller brucemiller merged commit c841e72 into brucemiller:master Aug 8, 2017
@tkw1536 tkw1536 deleted the makemanifest-improvements branch June 28, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants