Fix missing runtime_class warning #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating LaTeXML::MathGrammar, recent versions of Parse::RecDescent were generating a warning about the missing runtime_class option. This warning indiciated that the grammar may stop working with future versions of the RecDescent package. This commit adds the missing option to the call inside of Makefile.PL, ensuring that the default runtime Parse::RecDescent will continue to be used.
|
Cool! Thanks!! |
|
whoops... this doesn't actually work; at least not with Parse::RecDescent 1.965. if you do it seemingly doesn't accept the 3rd arg on the line. |
|
Oops, didn't consider that older dependency versions do not have the third argument. I will need to add a fallback case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating
LaTeXML::MathGrammar, recent versions ofParse::RecDescentwere generating a warning about the missingruntime_classoption. This warning indiciated that the grammar may stop working with future versions of the RecDescent package.This PR adds the missing option to the call inside of Makefile.PL, ensuring that the default runtime
Parse::RecDescentwill continue to be used.