/LaTeXML

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing runtime_class warning #867

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tkw1536 @brucemiller
@tkw1536
Contributor

tkw1536 commented Aug 29, 2017

When generating LaTeXML::MathGrammar, recent versions of Parse::RecDescent were generating a warning about the missing runtime_class option. This warning indiciated that the grammar may stop working with future versions of the RecDescent package.

This PR adds the missing option to the call inside of Makefile.PL, ensuring that the default runtime Parse::RecDescent will continue to be used.
@tkw1536
Fix missing runtime_class warning 
When generating LaTeXML::MathGrammar, recent versions of
Parse::RecDescent were generating a warning about the missing
runtime_class option. This warning indiciated that the grammar may stop
working with future versions of the RecDescent package.

This commit adds the missing option to the call inside of Makefile.PL,
ensuring that the default runtime Parse::RecDescent will continue to be
used.
Verified
This commit was signed with a verified signature.
@tkw1536 tkw1536 Tom Wiesing
GPG key ID: DC1F29F2BC78AB15 Learn about signing commits
Loading status checks…
61af370
@brucemiller

This comment has been minimized.

Sign in to view
Owner

brucemiller commented Aug 29, 2017

Cool! Thanks!!

@brucemiller brucemiller merged commit b5aa3d0 into brucemiller:master Aug 29, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brucemiller

This comment has been minimized.

Sign in to view
Owner

brucemiller commented Aug 29, 2017

whoops... this doesn't actually work; at least not with Parse::RecDescent 1.965. if you do make distclean to start fresh, then perl Makefile.PL and make, you get

Usage: perl -MLocalTest - <grammarfile> <classname>

it seemingly doesn't accept the 3rd arg on the line.
@tkw1536

This comment has been minimized.

Sign in to view
Contributor

tkw1536 commented Aug 29, 2017

Oops, didn't consider that older dependency versions do not have the third argument. I will need to add a fallback case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment