Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for older Parse::RecDescent versions #868

Merged
merged 1 commit into from Aug 31, 2017

Conversation

@tkw1536
Copy link
Contributor

tkw1536 commented Aug 30, 2017

Older versions of Parse::RecDescent did not support the third argument
to parser pre-compilation introduced in
b5aa3d0. This caused installation
problems for LaTeXML on older systems.

This PR fixes the problem by introducing a fallback that does not
use the third argument. This only gets triggered when the MathGrammar is
not created.

@tkw1536

This comment has been minimized.

Copy link
Contributor Author

tkw1536 commented Aug 30, 2017

@brucemiller can you check if this works on your problematic systems before merging?

@tkw1536

This comment has been minimized.

Copy link
Contributor Author

tkw1536 commented Aug 30, 2017

Makefile.PL Outdated
@@ -175,6 +175,9 @@ pure_all :: $(INST_LIBDIR)/LaTeXML/MathGrammar.pm
$(INST_LIBDIR)/LaTeXML/MathGrammar.pm: lib/LaTeXML/MathGrammar
$(PERLRUN) -MParse::RecDescent - lib/LaTeXML/MathGrammar LaTeXML::MathGrammar Parse::RecDescent
@$(PERLRUN) -e 'exit -e ("$(INST_LIBDIR)/LaTeXML/MathGrammar.pm") ? 0 : 1;' || \

This comment has been minimized.

Copy link
@dginev

dginev Aug 30, 2017

Collaborator

the leading @ on this line confused me enough to lose sight of the perlrun for my older question. What does leading @ do?

This comment has been minimized.

Copy link
@tkw1536

tkw1536 Aug 30, 2017

Author Contributor

Prevents the command from being echoed out. I added that to keep users from being confused by a 'fallback' message in the command, even though it is not relevant when not called.

This comment has been minimized.

Copy link
@dginev

dginev Aug 30, 2017

Collaborator

I see, thanks for educating me!

This comment has been minimized.

Copy link
@dginev

dginev Aug 30, 2017

Collaborator

I remember having known this years ago and then forgetting it, as bash syntax often goes.

@tkw1536 tkw1536 changed the title Bugix for older Parse::RecDescent versions Bugfix for older Parse::RecDescent versions Aug 30, 2017
@tkw1536 tkw1536 force-pushed the tkw1536:parser-runtime-warning-fix branch 2 times, most recently from fead8f6 to 0e174e5 Aug 30, 2017
@tkw1536

This comment has been minimized.

Copy link
Contributor Author

tkw1536 commented Aug 31, 2017

OK, I managed to test this on an older machine, and need to make one more change for this to work.

Older versions of Parse::RecDescent did not support the third argument
to parser pre-compilation introduced in
b5aa3d0. This caused installation
problems for LaTeXML on older systems.

This commit fixes the problem by introducing a fallback that does not
use the third argument. This only gets triggered when the MathGrammar is
not created.
@tkw1536 tkw1536 force-pushed the tkw1536:parser-runtime-warning-fix branch from 0e174e5 to 556aaa4 Aug 31, 2017
@brucemiller brucemiller merged commit 7aa2401 into brucemiller:master Aug 31, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tkw1536 tkw1536 deleted the tkw1536:parser-runtime-warning-fix branch Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.