Bugfix for older Parse::RecDescent versions - #868
Merged
brucemiller merged 1 commit intoAug 31, 2017
Conversation
Contributor
Author
|
@brucemiller can you check if this works on your problematic systems before merging? |
Contributor
Author
|
No, I actually mean -e inside the perl code to check if the given file exists.
… On 30. Aug 2017, at 15:39, Deyan Ginev ***@***.***> wrote:
@dginev commented on this pull request.
In Makefile.PL:
> @@ -175,6 +175,9 @@ pure_all :: $(INST_LIBDIR)/LaTeXML/MathGrammar.pm
$(INST_LIBDIR)/LaTeXML/MathGrammar.pm: lib/LaTeXML/MathGrammar
$(PERLRUN) -MParse::RecDescent - lib/LaTeXML/MathGrammar LaTeXML::MathGrammar Parse::RecDescent
+ @$(PERLRUN) -e 'exit -e ("$(INST_LIBDIR)/LaTeXML/MathGrammar.pm") ? 0 : 1;' || \
exit -e ? Don't you mean perl -e?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
dginev
reviewed
Aug 30, 2017
|
|
||
| $(INST_LIBDIR)/LaTeXML/MathGrammar.pm: lib/LaTeXML/MathGrammar | ||
| $(PERLRUN) -MParse::RecDescent - lib/LaTeXML/MathGrammar LaTeXML::MathGrammar Parse::RecDescent | ||
| @$(PERLRUN) -e 'exit -e ("$(INST_LIBDIR)/LaTeXML/MathGrammar.pm") ? 0 : 1;' || \ |
Collaborator
There was a problem hiding this comment.
the leading @ on this line confused me enough to lose sight of the perlrun for my older question. What does leading @ do?
Contributor
Author
There was a problem hiding this comment.
Prevents the command from being echoed out. I added that to keep users from being confused by a 'fallback' message in the command, even though it is not relevant when not called.
Collaborator
There was a problem hiding this comment.
I see, thanks for educating me!
Collaborator
There was a problem hiding this comment.
I remember having known this years ago and then forgetting it, as bash syntax often goes.
tkw1536
changed the title
tkw1536
force-pushed
the
parser-runtime-warning-fix
branch
2 times, most recently
from
August 31, 2017 15:54
fead8f6 to
0e174e5
Compare
Contributor
Author
|
OK, I managed to test this on an older machine, and need to make one more change for this to work. |
Older versions of Parse::RecDescent did not support the third argument to parser pre-compilation introduced in b5aa3d0. This caused installation problems for LaTeXML on older systems. This commit fixes the problem by introducing a fallback that does not use the third argument. This only gets triggered when the MathGrammar is not created.
tkw1536
force-pushed
the
parser-runtime-warning-fix
branch
from
August 31, 2017 15:59
0e174e5 to
556aaa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of Parse::RecDescent did not support the third argument
to parser pre-compilation introduced in
b5aa3d0. This caused installation
problems for LaTeXML on older systems.
This PR fixes the problem by introducing a fallback that does not
use the third argument. This only gets triggered when the MathGrammar is
not created.