Skip to content

Safe no-op for \advance when missing definition#880

Merged
brucemiller merged 1 commit into
brucemiller:masterfrom
dginev:issue-878
Oct 22, 2017
Merged

Safe no-op for \advance when missing definition#880
brucemiller merged 1 commit into
brucemiller:masterfrom
dginev:issue-878

Conversation

@dginev

@dginev dginev commented Oct 22, 2017

Copy link
Copy Markdown
Collaborator

Fixes #878

It upgrades the fatal message from the example:

Fatal:misdefined:LaTeXML::Package::Pool::__ANON__ Can't locate method 'valueOf' via 'missing'
	at /home/deyan/perl5/lib/perl5/LaTeXML/Package/TeX.pool.ltxml line 1221, <$IN> line 3.
	In Core::Definition::Primitive[\advance ... from TeX.pool.ltxml line 1221
	 <= Core::Stomach[@0x55f4b4414ec8] <= Core::Definition::Primitive[Begin] <= Core::Stomach[@0x55f4b4414ec8]
3 errors; 1 fatal error; 1 undefined macro[\AtBeginPart]

To a less critical error report:

Conversion complete: 3 errors; 1 undefined macro[\AtBeginPart].

Which is still sufficiently informative about the root cause. Feel free to review & merge @brucemiller

@brucemiller

Copy link
Copy Markdown
Owner

seems a good idea.

@brucemiller brucemiller merged commit 7194562 into brucemiller:master Oct 22, 2017
@dginev dginev deleted the issue-878 branch February 25, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants