New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe no-op for \advance when missing definition #880

Merged
merged 1 commit into from Oct 22, 2017

Conversation

Projects
None yet
2 participants
@dginev
Collaborator

dginev commented Oct 22, 2017

Fixes #878

It upgrades the fatal message from the example:

Fatal:misdefined:LaTeXML::Package::Pool::__ANON__ Can't locate method 'valueOf' via 'missing'
	at /home/deyan/perl5/lib/perl5/LaTeXML/Package/TeX.pool.ltxml line 1221, <$IN> line 3.
	In Core::Definition::Primitive[\advance ... from TeX.pool.ltxml line 1221
	 <= Core::Stomach[@0x55f4b4414ec8] <= Core::Definition::Primitive[Begin] <= Core::Stomach[@0x55f4b4414ec8]
3 errors; 1 fatal error; 1 undefined macro[\AtBeginPart]

To a less critical error report:

Conversion complete: 3 errors; 1 undefined macro[\AtBeginPart].

Which is still sufficiently informative about the root cause. Feel free to review & merge @brucemiller

@brucemiller

This comment has been minimized.

Owner

brucemiller commented Oct 22, 2017

seems a good idea.

@brucemiller brucemiller merged commit 7194562 into brucemiller:master Oct 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dginev dginev deleted the dginev:issue-878 branch Feb 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment