Robust preloads for daemon reruns, unlink cache for mathsvg #889
Conversation
d27fb34
into
brucemiller:master
1 check passed
1 check passed
Sounds reasonable; Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR is a bit more critical as it fixes a long-standing (and shocking) bug with daemonized runs.
Namely, the preload
insertPI
logic was wrongly modifying the preloads directly in the latexml object, so reruns would see all preloads as extension-free and mistreat classes as packages.if we
--preload=article.cls
, the first run would run correct, but overwrite the value toarticle
(no extension) and the second daemonized run would wrongly try to load article as a package. Pretty shocking! It is painfully obvious with--mathsvg
as the resulting\usepackage{article}
makes the SVG conversion fail entirely, which lead me to debugging & fixing.Additionally, I made sure to remove the cache file, which is something I borrowed from latexmlmath.