New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust preloads for daemon reruns, unlink cache for mathsvg #889

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@dginev
Collaborator

dginev commented Nov 20, 2017

This PR is a bit more critical as it fixes a long-standing (and shocking) bug with daemonized runs.

Namely, the preload insertPI logic was wrongly modifying the preloads directly in the latexml object, so reruns would see all preloads as extension-free and mistreat classes as packages.

if we --preload=article.cls, the first run would run correct, but overwrite the value to article (no extension) and the second daemonized run would wrongly try to load article as a package. Pretty shocking! It is painfully obvious with --mathsvg as the resulting \usepackage{article} makes the SVG conversion fail entirely, which lead me to debugging & fixing.

Additionally, I made sure to remove the cache file, which is something I borrowed from latexmlmath.

@dginev dginev added the bug label Nov 20, 2017

@brucemiller brucemiller merged commit d27fb34 into brucemiller:master Nov 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brucemiller

This comment has been minimized.

Owner

brucemiller commented Nov 28, 2017

Sounds reasonable; Thanks!

@dginev dginev deleted the dginev:robust-preloads-and-mathsvg branch Feb 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment