Use library to generate XML in maketests instead of system() #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presumably at some point convertFile returned the DOM node.
Oddly, there were two `gen_xml` methods. The one being used was shelling out to `latexml`. This doesn't work when working with a development environment where `latexml` isn't on the path. The other `gen_xml` method uses the library, which works with local development environments. A nice side-effect is this is the same approach used by `make test`, which seems more resilient somehow.
|
Yeah, hmm... I added that alternative in the middle of some debugging session; I don't think it was really intended to be permanent. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oddly, there were two
gen_xmlmethods. The one being used was shelling out tolatexml. I am running a development environment where I haven't runmake installand everything is in the working directory, so this doesn't work.The other
gen_xmlmethod uses the library, which works with my local development environment. A nice side-effect is this is the same approach used bymake test, which seems more resilient somehow.Also,
convertAndWriteFile()was broken, so I've fixed that.