/LaTeXML

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use library to generate XML in maketests instead of system() #906

Merged
merged 2 commits into from Dec 19, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bfirsh @brucemiller
@bfirsh
Contributor

bfirsh commented Dec 17, 2017

Oddly, there were two gen_xml methods. The one being used was shelling out to latexml. I am running a development environment where I haven't run make install and everything is in the working directory, so this doesn't work.

The other gen_xml method uses the library, which works with my local development environment. A nice side-effect is this is the same approach used by make test, which seems more resilient somehow.

Also, convertAndWriteFile() was broken, so I've fixed that.

bfirsh added some commits Dec 17, 2017

@bfirsh
Fix convertAndWriteFile 
Presumably at some point convertFile returned the DOM node.
Verified
This commit was signed with a verified signature.
@bfirsh bfirsh Ben Firshman
GPG key ID: 18296449E36D2F1E Learn about signing commits
0c47690
@bfirsh
Use library for maketests instead of system() 
Oddly, there were two `gen_xml` methods. The one being used was
shelling out to `latexml`. This doesn't work when working
with a development environment where `latexml` isn't on the path.

The other `gen_xml` method uses the library, which works with
local development environments. A nice side-effect is this is
the same approach used by `make test`, which seems more
resilient somehow.
Verified
This commit was signed with a verified signature.
@bfirsh bfirsh Ben Firshman
GPG key ID: 18296449E36D2F1E Learn about signing commits
Loading status checks…
bbdaee8
@brucemiller

This comment has been minimized.

Sign in to view
Owner

brucemiller commented Dec 19, 2017

Yeah, hmm... I added that alternative in the middle of some debugging session; I don't think it was really intended to be permanent. Thanks!

@brucemiller brucemiller merged commit 8633006 into brucemiller:master Dec 19, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bfirsh bfirsh deleted the bfirsh:use-library-for-maketests branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment