Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when core returns an empty document, ensure post still succeeds #964

Merged
merged 1 commit into from Mar 25, 2018

Conversation

@dginev
Copy link
Collaborator

@dginev dginev commented Mar 25, 2018

This causes cortex-specific troubles, as the return archive is empty, and hence no log information can be gathered.

This PR ensures if the core processing returns a completely empty document, without any elements set, it will still produce an HTML document and add the log file to the archive, when the target is .zip.

The specific arXiv document that hit this was 1802.05735

@brucemiller
Copy link
Owner

@brucemiller brucemiller commented Mar 25, 2018

Hm.... ok.

@brucemiller brucemiller merged commit 03a5bde into brucemiller:master Mar 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dginev dginev deleted the dginev:robust-post-for-empty-docs branch Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants