Integrate logs from separate bibliography converts in post-processing#969
Merged
Merged
Conversation
dginev
commented
Apr 13, 2018
| my ($state) = @_; # Remove current state frame | ||
| $$opts{searchpaths} = $state->lookupValue('SEARCHPATHS'); # save the searchpaths for post-processing | ||
| $state->popDaemonFrame; | ||
| $$state{status} = {}; |
Collaborator
Author
There was a problem hiding this comment.
this was the only place I had to touch the actual daemon core logic.
In essence, instead of immediately reset-ing the status hash after a conversion run is completed, I now reset it before a fresh run is started. This way I can still reuse the hash for passing on the status numbers to a parent converter object.
dginev
commented
Apr 13, 2018
| $$status{$type}{$subtype} += $$table{$subtype}; | ||
| } | ||
| } else { | ||
| $$status{$type} ||= 0; |
Collaborator
Author
There was a problem hiding this comment.
I have gotten used to being extra cautious from my Ruby days, let me know if you want these guards back @brucemiller
Collaborator
Author
There was a problem hiding this comment.
works just fine without them naturally
Owner
|
Looks good; let me know when you're done :> |
Collaborator
Author
|
Oh, i am done here. Feel free to review and merge. |
Owner
|
Cool! Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #916
A bit tricky, since managing the STDERR redirects is getting wild, but it works nicely. Unsure about the final log to print, attaching screenshots with this version. I did not want to indent the messages, so that automated regexes (e.g. from cortex) can still parse the log as usual.
Here are the logs converting the the issue example, with
master:And the logs after this PR is installed: