Skip to content

improved \endinput macro#971

Merged
brucemiller merged 2 commits into
brucemiller:masterfrom
dginev:endinput-fix
Apr 19, 2018
Merged

improved \endinput macro#971
brucemiller merged 2 commits into
brucemiller:masterfrom
dginev:endinput-fix

Conversation

@dginev

@dginev dginev commented Apr 19, 2018

Copy link
Copy Markdown
Collaborator

Fixes #957

@brucemiller please double-check this looks consistent with the TeXbook details, I still don't have one nearby.

I also added a handy test that ensures this won't regress.

The latest texlive babel now works correctly with this PR, and the example from the issue passes correctly.

@dginev

dginev commented Apr 19, 2018

Copy link
Copy Markdown
Collaborator Author

Had a small oversight, didn't realize readRawLine actually goes to the next line if the current one is finished. So I added an explicit check.

Should be good for review, done working here.

@brucemiller

Copy link
Copy Markdown
Owner

Cool! My first thought was something complicated. And then I thought maybe can read the rest of line & push it back to read later. Nice that you came upon the same idea!

@brucemiller brucemiller merged commit 3f943a5 into brucemiller:master Apr 19, 2018
@dginev dginev deleted the endinput-fix branch March 20, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants