Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved \endinput macro #971

Merged
merged 2 commits into from Apr 19, 2018

Conversation

@dginev
Copy link
Collaborator

dginev commented Apr 19, 2018

Fixes #957

@brucemiller please double-check this looks consistent with the TeXbook details, I still don't have one nearby.

I also added a handy test that ensures this won't regress.

The latest texlive babel now works correctly with this PR, and the example from the issue passes correctly.

@dginev

This comment has been minimized.

Copy link
Collaborator Author

dginev commented Apr 19, 2018

Had a small oversight, didn't realize readRawLine actually goes to the next line if the current one is finished. So I added an explicit check.

Should be good for review, done working here.

@brucemiller

This comment has been minimized.

Copy link
Owner

brucemiller commented Apr 19, 2018

Cool! My first thought was something complicated. And then I thought maybe can read the rest of line & push it back to read later. Nice that you came upon the same idea!

@brucemiller brucemiller merged commit 3f943a5 into brucemiller:master Apr 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dginev dginev deleted the dginev:endinput-fix branch Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.