Load order not preserved when using arrays for joinTo? #1610
Comments
|
Hi, @dsignr! Glad to help you! I'm trying to reproduce your issue. Could you, please, create a repo that reproduce your bug. That would save my and your time. Definitely, problem is hidden in I hope I can make a hotfix for you. Waiting for you response. |
|
Hi @denysdovhan, thank you for the quick response! Here is the repo: https://github.com/dsignr/brunch-issue-report Thank you and have a wonderful new year :) 👍 |
|
Gonna take a look at this ASAP. Happy holidays, @dsignr ! |
|
@denysdovhan Ok, thank you so much! :) 👍 |
|
Oh my, I've spend almost 2 hours trying to understand why your repo do not build anything an gives me EACCES error. The cause is That's just by the way, to let you know I'm working on it. |
|
Hey, @dsignr! Try to build your project with the latest version of Brunch from master. Works well for me.
"devDependencies": {
- "brunch": "^2.0.0",
+ "brunch": "brunch/brunch",
"javascript-brunch": "^2.0.0",
"css-brunch": "^2.0.0",
"uglify-js-brunch": "^2.0.0",
"clean-css-brunch": "^2.0.0",
"auto-reload-brunch": "^2.0.0",
"javascript-brunch": ">= 1.0 < 1.4",
"coffee-script-brunch": ">= 1.0 < 1.4",
"sass-brunch": "^2.7.0"
}I believe that will help. |
|
@dsignr take a look at my version of your repo. Compare with your. Mine works for me as expected. |
|
Wow, that was quite a detailed analysis and fix! Thanks a ton @denysdovhan :) much appreciated!! Wish you the best for this new year :) Closing this, since it's fixed.. 👍 |
|
@dsignr thank you for reporting! Glad to help you. Feel free to open issues if you have any problem with Brunch. |
|
No @denysdovhan, Thank YOU for your time. As someone who comes from Asset Pipeling, at first I didn't get brunch, but now I don't think I'll be going back haha 💃 |
|
Hi @denysdovhan this issue persists for me on a new project. Things I've tried:
I've created another repo: https://github.com/dsignr/brunch-issue-report-1610 The idea here is
Thank you for your time :) |
|
Sure, gonna take a look at your problem. |
|
@dsignr I've sent a PR with fixes that work for me: dsignr/brunch-issue-report-1610#1 We released a new version of Brunch —
That works thanks for
Just keep only one entry point (
Works for me with I believe that will help you. Also, I'd suggest you to use wrapping modules, because it's more safety that exposing everything into global scope. Moreover, better to use source maps — it's much more easier to debug using them. In any case, up to you. Thank you for reporting! |
|
Hi @denysdovhan , Gonna merge the PR now and update you very soon if it's resolved. Thanks again! :) |
|
@dsignr don't forget to close this issue |
|
@denysdovhan The first time I built it (after modifying my settings as per recommendation), it still didn't order them as expected, but, after a couple of runs, it now works fine! Gonna close this issue for now and will report back if things go south. Thanks a ton for your excellent support @denysdovhan! |
|
Sorry, this issue still persists. Strangely enough, it works on one machine, but fails on another. This was also tried by another member and confirmed to not working. More context: https://gitter.im/brunch/brunch |
|
@dsignr goddamn. Please, wrap everything in repo, if you could. Also, are you sure both of those machines are using the same version of Brunch and plugins? |
|
Hi @denysdovhan, it's the same repo (https://github.com/dsignr/brunch-issue-report-1610), same settings, nothing has changed, except when I tested it on another machine, I discovered it doesn't work, the fixes posted here don't work. Versions are the same too. So, I posted a question on brunch and a member on chat also tested it and verified it doesn't work :( Will be happy to share more info. |
|
I think this issue is relevant to this as well: #1121. I got hit by 1121 yesterday. After finally debugging, it seems my other machine was running NPM version 3.9.3 and my current machine was running 4.1.2. Downgrading to 3.9.3 resolved a lot of headaches, but, I will report back soon. This is my way of telling you I'm working on it :) |
Description
When using an array for joinTo, the load order doesn't seem to be preserved, even with an
orderkey specified.Expected behavior
I would like the files in my vendor directory (jQuery, Bootstrap) be loaded before the app scripts. Just in case this helps, I also have:
Actual behavior
What happens is that the order of concatenation is wrong:
appscripts are loaded firstjqueryandsemanticare loaded after my app scripts thus throwing an error.Environment
package.jsoncontents{ "name": "brunch-app", "description": "Description", "author": "Your Name", "version": "0.1.0", "repository": { "type": "git", "url": "" }, "scripts": { "start": "brunch watch --server", "build": "brunch build --production" }, "dependencies": {}, "devDependencies": { "brunch": "^2.0.0", "javascript-brunch": "^2.0.0", "css-brunch": "^2.0.0", "uglify-js-brunch": "^2.0.0", "clean-css-brunch": "^2.0.0", "auto-reload-brunch": "^2.0.0", "javascript-brunch": ">= 1.0 < 1.4", "coffee-script-brunch": ">= 1.0 < 1.4", "sass-brunch": "^2.7.0" } }brunch config contents
Other useful files, when present (log,
bower.jsonetc.)If there's an unexpected error during
brunch build/brunch watch, please attach the compilation log with the debug flag (-d) and stack traces enabled (export LOGGY_STACKS=true).If something worked with previous versions of brunch, but stopped with a newer one, please include these details as well.
P.S I come from a rails background, so, if I missed something basic, sorry 👍
The text was updated successfully, but these errors were encountered: