Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send inside the plugin the original path when target is not same as the source #1650

Closed
wants to merge 1 commit into from

Conversation

devel-pa
Copy link
Contributor

@devel-pa devel-pa commented Jan 25, 2017

#1648

I hope it didn't affect other plugins.
Tested with less-brunch (with targetExtension) and postcss-brunch.
Remove css-brunch as useless.

@shvaikalesh
Copy link
Contributor

shvaikalesh commented Jan 25, 2017

I would like to not introduce a new API, but rather join source maps in Brunch, not plugins.

@devel-pa
Copy link
Contributor Author

devel-pa commented Jan 25, 2017

It is not only about source maps. It's about the fact that postcss doesn't work at all in the current state.

@devel-pa
Copy link
Contributor Author

devel-pa commented Jan 25, 2017

Really, for production I don't give a damn on the source maps but on browser support.
Not forcing you to accept the pull request, as I said it's an idea.
Unfortunately I'm forced to revert all projects stacks to 2.8.2 times in any case

@paulmillr
Copy link
Member

paulmillr commented Jan 27, 2017

keeping this open until we fix postcss etc

@devel-pa
Copy link
Contributor Author

devel-pa commented Jan 27, 2017

I don't think is a postcss issue, I think is the fact that postcss needs more info.

@paulmillr paulmillr closed this Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants