Prepend “use strict” to wrapped modules by default. #413

Merged
merged 3 commits into from Nov 3, 2012

Conversation

Projects
None yet
2 participants
Owner

paulmillr commented Sep 13, 2012

Same as gh-412 but more robust and all Anthony’s work was squashed to one commit

paulmillr referenced this pull request Sep 13, 2012

Closed

Automatic Strict Mode #412

Contributor

anthonyshort commented Sep 13, 2012

Awesome, this will be super handy.

Owner

paulmillr commented Sep 13, 2012

I discovered just one possible issue: linters (jshint) by default think stuff should be in the strict mode, but they won’t see the brunch change.

This of course can be disabled simply by setting config option, like config.jshint.options.strict = no.

Owner

paulmillr commented Sep 14, 2012

Another issue: jade templates use with, which is prohibited by the strict mode. Researching passing a self: true compiler option to it.

visionmedia/jade#335

Owner

paulmillr commented Nov 3, 2012

Okay, i’m sick of the delays because of issues. Merged, but not by default.

paulmillr merged commit f2860d4 into master Nov 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment