Skip to content

directions for referencing git version of plug in don't work #6

Closed
es128 opened this Issue Mar 26, 2013 · 3 comments

2 participants

@es128
Brunch member
es128 commented Mar 26, 2013

npm doesn't run the prepublish script when a dependency is included from git (see npm/npm#3055), so it either needs to be run manually (include directions in readme) or the built lib included in the repo (I assume it would be overwritten by npm in the typical case). Or the direction for including from git could be removed here and in other similar repos.

Don't know what your preference would be, but I think I would go for including the compiled lib.

@paulmillr
Brunch member

my direction would be switching to javascript I think

@es128
Brunch member
es128 commented Mar 27, 2013

Not sure what you mean. Add directions about how to manually run the prepublish script when referencing the git repo, or include the compiled lib/index.js in the repo?

My vote is for the latter as long as it doesn't cause any problems in a typical npm install.

@paulmillr
Brunch member

include the compiled lib/index.js in the repo

this

@es128 es128 closed this Mar 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.