New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge brunch-typescript and typescript-brunch. #31

Merged
merged 7 commits into from Feb 9, 2017

Conversation

Projects
None yet
5 participants
@denysdovhan
Contributor

denysdovhan commented Feb 7, 2017

Hey, @baptistedonaux, @jpoehls, @xtity, @colinbate and @kripod! Hello from @brunch team!

We've noticed that there are two plugins for TypeScript in Brunch ecosystem:

  1. typescript-brunch
  2. brunch-typescript

The first one has a correct name (in according to plugin's styleguide), but it seems like this plugin was abandoned. The second one (this plugin) has more downloads, better API and seems like the most popular solution for TypeScript with Brunch.

We would like to update this plugin a bit (in corresponding to brunch/brunch#1666) and merge this one with typescript-brunch. Would be great (if you agree, of course) to move this plugin under @brunch organization, where we will take care of this plugin.

This PR introduce few changes for merging this plugin with typescript-brunch. Also, I've noticed #28 — gonna keep in mind those changes.

I need your confirmation. Do you agree with that? Would you like to move this plugin under @brunch org?

Hey, @joshheyse! We need you help to get NPM ownership for typescript-brunch package. Could you help us with that?

@joshheyse

This comment has been minimized.

Show comment
Hide comment
@joshheyse

joshheyse Feb 7, 2017

I'd be happy transfer the typescript-brunch package over to new ownership. Please let me know who I should coordinate with.

Keep up the good work!

joshheyse commented Feb 7, 2017

I'd be happy transfer the typescript-brunch package over to new ownership. Please let me know who I should coordinate with.

Keep up the good work!

@colinbate

This comment has been minimized.

Show comment
Hide comment
@colinbate

colinbate Feb 7, 2017

Collaborator

Ultimately the organizational decision belongs to @baptistedonaux, but I do like the idea of getting the name in line with other brunch plugins.

Also, while this plugin may be the best option for TypeScript with Brunch at the moment, it does lack proper integration with the TypeScript language server. Currently it just compiles each file in isolation. While this works, it makes normal error reporting essentially useless. I mention this because of your intention to standardize that (with line/col numbers, etc).

As it stands, the only practical way to use this plugin is with ignoreErrors: true set in the plugin config.

That said, the plugin works, but you typically need another mechanism to ensure your whole code base is free of compiler errors. And for incremental building, that might be all we need. However, I would like to support full language server integration when doing a full brunch build. I just haven't had the time unfortunately.

I'm not sure if everyone agrees, but I think that should be a priority if things move organizations.

Collaborator

colinbate commented Feb 7, 2017

Ultimately the organizational decision belongs to @baptistedonaux, but I do like the idea of getting the name in line with other brunch plugins.

Also, while this plugin may be the best option for TypeScript with Brunch at the moment, it does lack proper integration with the TypeScript language server. Currently it just compiles each file in isolation. While this works, it makes normal error reporting essentially useless. I mention this because of your intention to standardize that (with line/col numbers, etc).

As it stands, the only practical way to use this plugin is with ignoreErrors: true set in the plugin config.

That said, the plugin works, but you typically need another mechanism to ensure your whole code base is free of compiler errors. And for incremental building, that might be all we need. However, I would like to support full language server integration when doing a full brunch build. I just haven't had the time unfortunately.

I'm not sure if everyone agrees, but I think that should be a priority if things move organizations.

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 7, 2017

Contributor

@joshheyse please, add @paulmillr as an owner to your package.

Contributor

denysdovhan commented Feb 7, 2017

@joshheyse please, add @paulmillr as an owner to your package.

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 8, 2017

Contributor

@colinbate I've updated this plugin a bit. Didn't change logic. You are welcome to collaborate.

@baptistedonaux what do you think about transfer this plugin under Brunch org? If you agree, then here is a simple to-do:

  • Merge this PR
  • Transfer ownership of this repo to me (you don't have permissions to Brunch org, so you can't transfer this repo directly)
  • Rename package to typescript-brunch (I'll do it by myself)
  • Publish new version of typescript-brunch
  • Deprecate brunch-typescript on NPM

Waiting for your response.

Contributor

denysdovhan commented Feb 8, 2017

@colinbate I've updated this plugin a bit. Didn't change logic. You are welcome to collaborate.

@baptistedonaux what do you think about transfer this plugin under Brunch org? If you agree, then here is a simple to-do:

  • Merge this PR
  • Transfer ownership of this repo to me (you don't have permissions to Brunch org, so you can't transfer this repo directly)
  • Rename package to typescript-brunch (I'll do it by myself)
  • Publish new version of typescript-brunch
  • Deprecate brunch-typescript on NPM

Waiting for your response.

@denysdovhan denysdovhan changed the title from [WIP] Upgrade brunch-typescript and typescript-brunch. to Upgrade brunch-typescript and typescript-brunch. Feb 9, 2017

@baptistedonaux

This comment has been minimized.

Show comment
Hide comment
@baptistedonaux

baptistedonaux Feb 9, 2017

Collaborator

Initially this plugin has been created to give a TypeScript compilator up-to-date for Brunch project. I think that to help Brunch organization to grow, this plugin must be integrated in Brunch stack.

Thank @colinbate for your features and improvements.

Collaborator

baptistedonaux commented Feb 9, 2017

Initially this plugin has been created to give a TypeScript compilator up-to-date for Brunch project. I think that to help Brunch organization to grow, this plugin must be integrated in Brunch stack.

Thank @colinbate for your features and improvements.

@baptistedonaux baptistedonaux merged commit b4c24cc into brunch:master Feb 9, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@baptistedonaux

This comment has been minimized.

Show comment
Hide comment
@baptistedonaux

baptistedonaux Feb 9, 2017

Collaborator

@denysdovhan Can you removed your fork ? I can't transfer it to you.

Collaborator

baptistedonaux commented Feb 9, 2017

@denysdovhan Can you removed your fork ? I can't transfer it to you.

@denysdovhan denysdovhan deleted the denysdovhan:update branch Feb 9, 2017

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 9, 2017

Contributor

@baptistedonaux done. I've deleted my fork.

Contributor

denysdovhan commented Feb 9, 2017

@baptistedonaux done. I've deleted my fork.

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 9, 2017

Contributor

@baptistedonaux got it. Thank you. Moving to the Brunch repo.

Contributor

denysdovhan commented Feb 9, 2017

@baptistedonaux got it. Thank you. Moving to the Brunch repo.

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 9, 2017

Contributor

@baptistedonaux done. Repo is under Brunch org.

Contributor

denysdovhan commented Feb 9, 2017

@baptistedonaux done. Repo is under Brunch org.

@baptistedonaux

This comment has been minimized.

Show comment
Hide comment
@baptistedonaux

baptistedonaux Feb 9, 2017

Collaborator

@denysdovhan How can I "Deprecate brunch-typescript on NPM" ? Do I have remove repository ?

Collaborator

baptistedonaux commented Feb 9, 2017

@denysdovhan How can I "Deprecate brunch-typescript on NPM" ? Do I have remove repository ?

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 9, 2017

Contributor

@baptistedonaux nonono, just execute this command:

npm deprecate brunch-typescript "brunch-typescript is unsupported, use typescript-brunch instead"

But let's wait for a while. We have to publish new version of typescript-brunch plugin before.

Contributor

denysdovhan commented Feb 9, 2017

@baptistedonaux nonono, just execute this command:

npm deprecate brunch-typescript "brunch-typescript is unsupported, use typescript-brunch instead"

But let's wait for a while. We have to publish new version of typescript-brunch plugin before.

@baptistedonaux

This comment has been minimized.

Show comment
Hide comment
@baptistedonaux

baptistedonaux Feb 9, 2017

Collaborator

Perfect ! I wait your feedback.

Collaborator

baptistedonaux commented Feb 9, 2017

Perfect ! I wait your feedback.

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 9, 2017

Contributor

@baptistedonaux I've asked @paulmillr to publish new version of typescript-brunch. Waiting for response from him.

@joshheyse, did you give NPM ownership to @paulmillr?

Contributor

denysdovhan commented Feb 9, 2017

@baptistedonaux I've asked @paulmillr to publish new version of typescript-brunch. Waiting for response from him.

@joshheyse, did you give NPM ownership to @paulmillr?

@joshheyse

This comment has been minimized.

Show comment
Hide comment
@joshheyse

joshheyse Feb 10, 2017

I gave @paulmillr access today. Let me know if there are issues

joshheyse commented Feb 10, 2017

I gave @paulmillr access today. Let me know if there are issues

@paulmillr

This comment has been minimized.

Show comment
Hide comment
@paulmillr

paulmillr Feb 10, 2017

Member

2.2 is out

Member

paulmillr commented Feb 10, 2017

2.2 is out

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan

denysdovhan Feb 10, 2017

Contributor

@baptistedonaux please, deprecate old brunch-typescript plugin.

Contributor

denysdovhan commented Feb 10, 2017

@baptistedonaux please, deprecate old brunch-typescript plugin.

@baptistedonaux

This comment has been minimized.

Show comment
Hide comment
@baptistedonaux
Collaborator

baptistedonaux commented Feb 10, 2017

@denysdovhan Done

@denysdovhan

This comment has been minimized.

Show comment
Hide comment
@denysdovhan
Contributor

denysdovhan commented Feb 10, 2017

@denysdovhan denysdovhan changed the title from Upgrade brunch-typescript and typescript-brunch. to Merge brunch-typescript and typescript-brunch. Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment