Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Merge brunch-typescript and typescript-brunch. #31
We've noticed that there are two plugins for TypeScript in Brunch ecosystem:
The first one has a correct name (in according to plugin's styleguide), but it seems like this plugin was abandoned. The second one (this plugin) has more downloads, better API and seems like the most popular solution for TypeScript with Brunch.
We would like to update this plugin a bit (in corresponding to brunch/brunch#1666) and merge this one with
This PR introduce few changes for merging this plugin with
I need your confirmation. Do you agree with that? Would you like to move this plugin under @brunch org?
Hey, @joshheyse! We need you help to get NPM ownership for
Ultimately the organizational decision belongs to @baptistedonaux, but I do like the idea of getting the name in line with other brunch plugins.
Also, while this plugin may be the best option for TypeScript with Brunch at the moment, it does lack proper integration with the TypeScript language server. Currently it just compiles each file in isolation. While this works, it makes normal error reporting essentially useless. I mention this because of your intention to standardize that (with line/col numbers, etc).
As it stands, the only practical way to use this plugin is with
That said, the plugin works, but you typically need another mechanism to ensure your whole code base is free of compiler errors. And for incremental building, that might be all we need. However, I would like to support full language server integration when doing a full
I'm not sure if everyone agrees, but I think that should be a priority if things move organizations.
@colinbate I've updated this plugin a bit. Didn't change logic. You are welcome to collaborate.
@baptistedonaux what do you think about transfer this plugin under Brunch org? If you agree, then here is a simple to-do:
Waiting for your response.
Initially this plugin has been created to give a TypeScript compilator up-to-date for Brunch project. I think that to help Brunch organization to grow, this plugin must be integrated in Brunch stack.
Thank @colinbate for your features and improvements.