This repository was archived by the owner on Feb 9, 2023. It is now read-only.
Emit js/jsx files using new targetExtension API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudi-c
force-pushed
the
master
branch
2 times, most recently
from
c32eda8 to
cd2717d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of brunch (>2.10) have a targetExtension API which allows changing the extension of the file as it moves to the next stage of the pipeline. It's necessary to change this to
.jsor.jsxsince that's what the Typescript compiler outputs, and otherwise it will get ignored by further stages (e.g. babel).The targetExtension is changed based on the jsx option passed to the Typescript compiler (see https://www.typescriptlang.org/docs/handbook/jsx.html)
Also addresses #34