New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit js/jsx files using new targetExtension API #39

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
@rudi-c
Contributor

rudi-c commented Jul 11, 2017

Newer versions of brunch (>2.10) have a targetExtension API which allows changing the extension of the file as it moves to the next stage of the pipeline. It's necessary to change this to .js or .jsx since that's what the Typescript compiler outputs, and otherwise it will get ignored by further stages (e.g. babel).

The targetExtension is changed based on the jsx option passed to the Typescript compiler (see https://www.typescriptlang.org/docs/handbook/jsx.html)

Also addresses #34

@shvaikalesh shvaikalesh merged commit 7e99449 into brunch:master Aug 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment