Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurate rate calculation #12

Open
wants to merge 2 commits into
base: master
from

Conversation

@Liath
Copy link
Collaborator

commented Jul 16, 2019

Per #11, some rates aren't possible due to rounding and we can't specify sub-10ms in core.async/timeout because of how it buckets requests. Per @dball's advice on the clojurians Slack I took a swing at replacing timeout with java.util.concurrent.ScheduledExecutorService. It fairly accurately represents the lower values from #11 correctly but I'm not confident it's the best solution. It breaks one of this projects goals of not needing an additional thread and I'd really rather @brunoV signed off on that.

I'd love to have the script that was used to generate the table in the README for comparison...

A probably naive implementation with java.util.concurrent.ScheduledEx…
…ecutorService instead of core.async/timeout

@Liath Liath requested a review from brunoV Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.