New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect paths #55

Closed
sugarshin opened this Issue Mar 22, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@sugarshin
Copy link
Contributor

sugarshin commented Mar 22, 2018

Hi,

Thank you for make this plugin!
I try to this with html-webpack-plugin . following results. Icon path is incorrect.

<head>
  <meta charset="utf-8">
  <title></title>
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <meta name="title">
  <meta name="author">
  <meta name="description">
  <meta property="og:title">
  <meta property="og:description">
  <meta property="og:type">
  <meta property="og:image">
  <meta property="og:url">
  <meta property="og:site_name">
  <link rel="apple-touch-icon" sizes="114x114" href="/assets//apple-touch-icon-114x114.png">
  <link rel="apple-touch-icon" sizes="120x120" href="/assets//apple-touch-icon-120x120.png">
  <link rel="apple-touch-icon" sizes="144x144" href="/assets//apple-touch-icon-144x144.png">
  <link rel="apple-touch-icon" sizes="152x152" href="/assets//apple-touch-icon-152x152.png">
  <link rel="apple-touch-icon" sizes="180x180" href="/assets//apple-touch-icon-180x180.png">
  <link rel="apple-touch-icon" sizes="57x57" href="/assets//apple-touch-icon-57x57.png">
  <link rel="apple-touch-icon" sizes="60x60" href="/assets//apple-touch-icon-60x60.png">
  <link rel="apple-touch-icon" sizes="72x72" href="/assets//apple-touch-icon-72x72.png">
  <link rel="apple-touch-icon" sizes="76x76" href="/assets//apple-touch-icon-76x76.png">
  <link rel="icon" type="image/png" sizes="16x16" href="/assets//favicon-16x16.png">
  <link rel="icon" type="image/png" sizes="32x32" href="/assets//favicon-32x32.png">
  <link rel="manifest" href="/assets//manifest.json">
  <link rel="shortcut icon" href="/assets/favicon.ico">
  <meta name="apple-mobile-web-app-capable" content="yes">
  <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
  <meta name="apple-mobile-web-app-title" content="blog.sugarshin.net">
  <meta name="application-name" content="blog.sugarshin.net">
  <meta name="mobile-web-app-capable" content="yes">
  <meta name="msapplication-TileColor" content="#fff">
  <meta name="msapplication-TileImage" content="/mstile-144x144.png">
  <meta name="msapplication-config" content="/browserconfig.xml">
  <meta name="theme-color" content="#fff">
  <link href="/assets/vendor-6bf879f5d556d65add330eeaac6d483d.css" rel="stylesheet">
  <link href="/assets/app-22e2dbacc5a7e8abcf73518a523be7e3.css" rel="stylesheet">
</head>

webpack.config.js

{
  output: {
    path: path.resolve(__dirname, '..', buildDir),
    publicPath: '/',
    ...
  },
  plugins: [
    new HtmlPlugin(),
    new WebappPlugin({
      logo: './src/images/p.jpg',
      prefix: 'assets/',
      cache: false,
      favicons: configuration,
    }),
    ...
  ],
  ...
}

dir

.
├── assets
│   ├── app-22e2dbacc5a7e8abcf73518a523be7e3.css
│   ├── app-30c6104a4d8c1e4465e9.js
│   ├── fonts
│   ├── images
│   ├── vendor-656de7e8ef127b850672.js
│   ├── vendor-6bf879f5d556d65add330eeaac6d483d.css
│   ├── android-chrome-144x144.png
│   ├── android-chrome-192x192.png
│   ├── android-chrome-256x256.png
│   ├── android-chrome-36x36.png
│   ├── android-chrome-384x384.png
│   ├── android-chrome-48x48.png
│   ├── android-chrome-512x512.png
│   ├── android-chrome-72x72.png
│   ├── android-chrome-96x96.png
│   ├── apple-touch-icon-114x114.png
│   ├── apple-touch-icon-120x120.png
│   ├── apple-touch-icon-144x144.png
│   ├── apple-touch-icon-152x152.png
│   ├── apple-touch-icon-167x167.png
│   ├── apple-touch-icon-180x180.png
│   ├── apple-touch-icon-57x57.png
│   ├── apple-touch-icon-60x60.png
│   ├── apple-touch-icon-72x72.png
│   ├── apple-touch-icon-76x76.png
│   ├── apple-touch-icon-precomposed.png
│   ├── apple-touch-icon.png
│   ├── browserconfig.xml
│   ├── favicon-16x16.png
│   ├── favicon-32x32.png
│   ├── favicon.ico
│   ├── manifest.json
│   ├── mstile-144x144.png
│   ├── mstile-150x150.png
│   ├── mstile-310x150.png
│   ├── mstile-310x310.png
│   └── mstile-70x70.png
└── index.html

Thank you.

@brunocodutra

This comment has been minimized.

Copy link
Owner

brunocodutra commented Mar 22, 2018

Thanks for taking the time to open an issue.

I need a little more context, you mean the icon paths linked in the HTML are incorrect? If so, which ones and what did you expect instead?

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

sugarshin commented Mar 22, 2018

Thank you for reply.

Actually there is a difference between npm published codes and master codes.

@brunocodutra

This comment has been minimized.

Copy link
Owner

brunocodutra commented Mar 22, 2018

webapp-webpack-plugin requires transpiling, so unfortunately it's not possible to use it directly from master.

I'm about to publish some fixes for incorrect paths to Windows icons (see #51), is that maybe what you are observing?

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

sugarshin commented Mar 22, 2018

Yep, You need to publish the code that compiled the latest master code to npm.
I will issue a pull request to solve this problem.

@brunocodutra

This comment has been minimized.

Copy link
Owner

brunocodutra commented Mar 22, 2018

v1.3.1 is out, please let me know if it works for you.

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

sugarshin commented Mar 22, 2018

Thank you!

@sugarshin sugarshin closed this Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment