Support html-webpack-plugin v4 #131
Conversation
Pull Request Test Coverage Report for Build 598
💛 - Coveralls |
| @@ -14,6 +14,14 @@ module.exports.tap = (tappable, hook, name, plugin) => ( | |||
| : tappable.plugin(hook, plugin) | |||
| ); | |||
|
|
|||
| module.exports.tapHtml = (tappable, name, plugin) => { | |||
| const HtmlWebpackPlugin = require('html-webpack-plugin'); | |||
There was a problem hiding this comment.
It's using "html-webpack-plugin": "^3.2.0" from package.json here.
HtmlWebpackPlugin.getHooks will always be undefined.
Or at least that's what I'm noticing testing it locally.
Makes sense it's undefined tho, the version with getHooks is html-webpack-plugin@next.
There was a problem hiding this comment.
Unless I misunderstood, html-webpack-plugin ist a dev-dependency and should not be installed if you consume webapp-webpack-plugin as a dependency, meaning it should pick whichever version you have in your package.json.
There was a problem hiding this comment.
I think you're right, my understanding of npm dependencies is lacking at best.
|
@brunocodutra can we have this merged? |
|
@bj00rn yes! The only reason I didn't merge it yet though is the fact it lacks unit tests and it's getting increasingly hard to set them up such that it works for legacy versions of Webpack and HtmlWebpackPlugin, so I've been fiddling with the idea of releasing a major version. |
brunocodutra
force-pushed
the
html-webpack-plugin-4
branch
from
c63e723
to
d5516b7
Compare
Closes #128