New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `prepare` #56

Merged
merged 2 commits into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@sugarshin
Copy link
Contributor

sugarshin commented Mar 22, 2018

Can you check this please.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 22, 2018

Pull Request Test Coverage Report for Build 232

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.556%

Totals Coverage Status
Change from base Build 229: 0.0%
Covered Lines: 81
Relevant Lines: 81

💛 - Coveralls
@brunocodutra

This comment has been minimized.

Copy link
Owner

brunocodutra commented Mar 22, 2018

Thanks for the patch!

I actually wasn't aware that could be done and it's a great idea, but I think we should be hooking up prepare instead of prepublishOnly?

See npm/npm#3055

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

sugarshin commented Mar 22, 2018

Thanks for reply.

I didn’t know prepare . I think prepare is more better. I’ll update PR later.
Thank you!

@sugarshin sugarshin force-pushed the sugarshin:use-prepublish-only branch from ddfae2b to 716d768 Mar 22, 2018

@sugarshin sugarshin changed the title Use prepublishOnly Use `prepare` Mar 22, 2018

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

sugarshin commented Mar 22, 2018

@brunocodutra Please re-check.

@brunocodutra

This comment has been minimized.

Copy link
Owner

brunocodutra commented Mar 23, 2018

Works like a charm, thanks again!

@brunocodutra brunocodutra merged commit f23a47c into brunocodutra:master Mar 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.556%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment