Static analyzer fixes

brunophilipe · Mar 5, 2021 · dfd4976 · dfd4976
1 parent a985468
commit dfd4976
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/Cakebrew.xcodeproj/project.pbxproj b/Cakebrew.xcodeproj/project.pbxproj
@@ -1052,6 +1052,7 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_OBJC_EXPLICIT_OWNERSHIP_TYPE = YES;
 				CODE_SIGN_IDENTITY = "Mac Developer";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
@@ -1081,6 +1082,7 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_OBJC_EXPLICIT_OWNERSHIP_TYPE = YES;
 				CODE_SIGN_IDENTITY = "Mac Developer";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;

diff --git a/Cakebrew/BPHomebrewInterface.m b/Cakebrew/BPHomebrewInterface.m
@@ -300,12 +300,14 @@ - (NSString*)performWrappedBrewCommandWithArguments:(NSArray*)arguments
 {
 	NSString __block *finalOutput = nil;
 
-	dispatch_sync(_taskOperationsQueue, ^{
+	dispatch_queue_t queue = _taskOperationsQueue;
+
+	dispatch_sync(queue, ^{
 		NSMutableString *output = [NSMutableString new];
 
 		[self performBrewCommandWithArguments:arguments
 					  wrapsSynchronousRequest:YES
-										queue:_taskOperationsQueue
+										queue:queue
 							  dataReturnBlock:^(NSString *partialOutput)
 		{
 			[output appendString:partialOutput];

diff --git a/Dependencies/PXSourceList b/Dependencies/PXSourceList