New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is my first ever GitHub PR with just a minor addition #106

Merged
merged 6 commits into from Nov 17, 2016

Conversation

Projects
None yet
2 participants
@SiteEffect
Contributor

SiteEffect commented Nov 17, 2016

Description

Providing an empty template file for already supported Google Analytics.

Motivation and Context

We support Google Analytics by including a file inside the index.php but we do not yet provide a template file. Here it is.

How Has This Been Tested?

On my repository and local branch.

Types of changes

  • Very minor fix.
@SiteEffect

This comment has been minimized.

Contributor

SiteEffect commented Nov 17, 2016

Don't hate me btw, you can close this immediately.

@Obihoernchen

This comment has been minimized.

Collaborator

Obihoernchen commented Nov 17, 2016

Please add a note to the file that it should be renamed to analyticstracking.php afterwards.
Then I'll merge your very first github PR and everybody will celebrate this 💃

@SiteEffect

This comment has been minimized.

Contributor

SiteEffect commented Nov 17, 2016

The shame 💯

@Obihoernchen Obihoernchen merged commit 77e1a31 into brusselopole:master Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment