New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "dead" trainer Pokémon by default, add option to show all #366

Merged
merged 3 commits into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@michikrug
Collaborator

michikrug commented Feb 26, 2018

Description

Hide "dead" Pokémon on the trainer page by default and add an option to show all.

Motivation and Context

The list of Pokémon of each trainer can be really long.
Thus, only show the current deployed ones by default.

How Has This Been Tested?

Not tested cause of cherry picked lines of code.
But running in my code for a really long time without issues.

Screenshots (if appropriate):

bildschirmfoto 2018-02-26 um 14 38 07

To Do:

Add translations for the "show all" entry for all other languages than EN/DE.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@Obihoernchen

works fine

@Obihoernchen Obihoernchen merged commit ae48fe7 into brusselopole:master Apr 18, 2018

1 check passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details

Student1978 added a commit to Student1978/Worldopole that referenced this pull request Apr 19, 2018

Merge pull request #1 from brusselopole/master
Hide "dead" trainer Pokémon by default, add option to show all (brusselopole#366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment