New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu with submenu #368

Merged
merged 9 commits into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@Student1978
Contributor

Student1978 commented Mar 27, 2018

Description

Extended by submenu functionality

grafik

Motivation and Context

I have many items on the menu, and need submenus

How Has This Been Tested?

Work at my Worldopole instance

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@123FLO321

Haven't tested it yet but looks good otherwise.

index.php Outdated
@@ -4,6 +4,66 @@
include_once('functions.php');
include_once('core/process/data.loader.php');
function menuitems($menu, $level) {

This comment has been minimized.

@123FLO321

123FLO321 Mar 27, 2018

Collaborator

We don't have functions in the index.php
You should probably move it to functions.php until it gets refactored.
And menuitems to printMenuitems or something similar so we can understand what the function does more easily.

@Obihoernchen

Please change the text color back to grey.
Thank you :)

Student1978 added some commits Apr 19, 2018

Merge pull request #1 from brusselopole/master
Hide "dead" trainer Pokémon by default, add option to show all (#366)

@Obihoernchen Obihoernchen merged commit adf7596 into brusselopole:master Apr 23, 2018

1 check passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment