New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big code formatting refactor #79

Merged
merged 45 commits into from Oct 2, 2016

Conversation

Projects
None yet
1 participant
@Obihoernchen
Collaborator

Obihoernchen commented Oct 1, 2016

Description

  • Replaces all indent spaces with TABs
  • Improve overall code formatting
  • Replace some Brusselopole strings with site_name (7100d17, d4ea15a, fb1d7ab)
  • Improve script loading order (b6eb964)
  • Fix some link syntax in translations.json (e25b36e)
  • Remove stray </div> (84b2cb4)
  • Add some more img alt tags (a8da527)
  • Remove unused twitter url (974eaf2)
  • Minor text fixes

Motivation and Context

Spaces are bad. And a mixture between spaces and tabs is even worse!
The code formatting was a total mess in some files. This PR tries to improve this.
https://youtu.be/SsoOG6ZeyUI

How Has This Been Tested?

locally
Please do further tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
@Obihoernchen

This comment has been minimized.

Collaborator

Obihoernchen commented Oct 1, 2016

If ok squash and merge please ;)

Obihoernchen added some commits Oct 1, 2016

Fix merge conflict
Merge branch 'master' of https://github.com/brusselopole/Worldopole into formatting-refactor

 Conflicts:
	index.php
Remove unused twitter url
Change twitter link at the end of file instead

@Obihoernchen Obihoernchen merged commit b2464bc into brusselopole:master Oct 2, 2016

@Obihoernchen Obihoernchen deleted the Obihoernchen:formatting-refactor branch Oct 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment