Skip to content

Commit

Permalink
Use testing package only in unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
brutella committed May 13, 2015
1 parent 55a37ca commit 66c9582
Show file tree
Hide file tree
Showing 16 changed files with 426 additions and 192 deletions.
10 changes: 7 additions & 3 deletions uvr/1611/heatmeter_test.go
Expand Up @@ -2,13 +2,17 @@ package uvr1611

import (
"github.com/brutella/gouvr/uvr"
"github.com/stretchr/testify/assert"
"testing"
)

func TestHeatmetersEnabled(t *testing.T) {
b := uvr.Byte(0x2) // 0000 0010
h1, h2 := AreHeatMetersEnabled(uvr.NewHeatMeterRegister(b))
assert.False(t, h1)
assert.True(t, h2)

if is, want := h1, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := h2, true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
}
40 changes: 29 additions & 11 deletions uvr/1611/input_value_test.go
Expand Up @@ -2,7 +2,6 @@ package uvr1611

import (
"github.com/brutella/gouvr/uvr"
"github.com/stretchr/testify/assert"
"testing"
)

Expand All @@ -13,8 +12,12 @@ func TestTemperatureInputValue(t *testing.T) {
})

input_type, f := DecodeInputValue(value)
assert.Equal(t, input_type, InputTypeTemperature)
assert.Equal(t, f, 8.0)
if is, want := input_type, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := f, float32(8.0); is != want {
t.Fatalf("is=%v want=%v", is, want)
}
}

func TestNegativeTemperatureInputValue(t *testing.T) {
Expand All @@ -24,22 +27,33 @@ func TestNegativeTemperatureInputValue(t *testing.T) {
})

input_type, f := DecodeInputValue(value)
assert.Equal(t, input_type, InputTypeTemperature)
assert.Equal(t, f, -2.6)
if is, want := input_type, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := f, float32(-2.6); is != want {
t.Fatalf("is=%v want=%v", is, want)
}
}

func TestRoomTemperatureInputValue(t *testing.T) {
value := uvr.NewValue([]uvr.Byte{
uvr.Byte(0x50), // 0101 0000
uvr.Byte(0x74), // 0111 0100
})

input_type, f := DecodeInputValue(value)
assert.Equal(t, input_type, InputTypeRoomTemperature)
assert.Equal(t, f, 8.0)

if is, want := input_type, InputTypeRoomTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := f, float32(8.0); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

mode := RoomTemperatureModeFromValue(value)
assert.Equal(t, mode, RoomTemperatureModeLowering)

if is, want := mode, RoomTemperatureModeLowering; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
}

func TestDigitalInputValue(t *testing.T) {
Expand All @@ -48,7 +62,9 @@ func TestDigitalInputValue(t *testing.T) {
uvr.Byte(0x90), // 1001 0000
})

assert.True(t, IsDigitalInputValueOn(value))
if is, want := IsDigitalInputValueOn(value), true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
}

func TestUnusedInputValue(t *testing.T) {
Expand All @@ -57,5 +73,7 @@ func TestUnusedInputValue(t *testing.T) {
uvr.Byte(0x00), // 0000 0000
})

assert.True(t, IsUnusedInputValue(value))
if is, want := IsUnusedInputValue(value), true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
}
273 changes: 186 additions & 87 deletions uvr/1611/integration_test.go
Expand Up @@ -2,11 +2,10 @@ package uvr1611

import (
"github.com/brutella/gouvr/uvr"
"github.com/stretchr/testify/assert"
"testing"
)

func TestIntegration(test *testing.T) {
func TestIntegration(t *testing.T) {
log := "../../logs/integration.log"

packetReceiver := NewPacketReceiver()
Expand All @@ -23,96 +22,196 @@ func TestIntegration(test *testing.T) {
byteDecoder.Reset()
packetDecoder.Reset()
})
err := replayer.Replay(log)
assert.Nil(test, err)
assert.NotNil(test, p)

t, v := DecodeInputValue(p.Input1)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 8.5)

t, v = DecodeInputValue(p.Input2)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 55.6)

t, v = DecodeInputValue(p.Input3)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 45.5)

t, v = DecodeInputValue(p.Input4)
assert.Equal(test, t, InputTypeDigital)
assert.Equal(test, v, 0.0)

t, v = DecodeInputValue(p.Input5)
assert.Equal(test, t, InputTypeDigital)
assert.Equal(test, v, 0.0)

t, v = DecodeInputValue(p.Input6)
assert.Equal(test, t, InputTypeDigital)
assert.Equal(test, v, 0.0)

t, v = DecodeInputValue(p.Input7)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 22.4)

t, v = DecodeInputValue(p.Input8)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 1.5)

t, v = DecodeInputValue(p.Input9)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 73.9)

t, v = DecodeInputValue(p.Input10)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 46.7)

t, v = DecodeInputValue(p.Input11)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 37.9)

t, v = DecodeInputValue(p.Input12)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 2.6)

t, v = DecodeInputValue(p.Input13)
if err := replayer.Replay(log); err != nil {
t.Fatal(err)
}

it, v := DecodeInputValue(p.Input1)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(8.5); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input2)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(55.6); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input3)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(45.5); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input4)
if is, want := it, InputTypeDigital; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(0.0); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input5)
if is, want := it, InputTypeDigital; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(0.0); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input6)
if is, want := it, InputTypeDigital; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(0.0); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input7)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(22.4); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input8)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(1.5); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input9)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(73.9); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input10)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(46.7); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input11)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(37.9); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input12)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(2.6); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input13)
m := RoomTemperatureModeFromValue(p.Input13)
assert.Equal(test, t, InputTypeRoomTemperature)
assert.Equal(test, v, 21.0)
assert.Equal(test, m, RoomTemperatureModeAutomatic)

t, v = DecodeInputValue(p.Input14)
if is, want := it, InputTypeRoomTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(21.0); is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := m, RoomTemperatureModeAutomatic; is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input14)
m = RoomTemperatureModeFromValue(p.Input14)
assert.Equal(test, t, InputTypeRoomTemperature)
assert.Equal(test, v, 20.9)
assert.Equal(test, m, RoomTemperatureModeAutomatic)

t, v = DecodeInputValue(p.Input15)
assert.Equal(test, t, InputTypeTemperature)
assert.Equal(test, v, 17.5)

t, v = DecodeInputValue(p.Input16)
assert.Equal(test, t, InputTypeVolumeFlow)
assert.Equal(test, v, 0.0)
if is, want := it, InputTypeRoomTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(20.9); is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := m, RoomTemperatureModeAutomatic; is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input15)
if is, want := it, InputTypeTemperature; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(17.5); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

it, v = DecodeInputValue(p.Input16)
if is, want := it, InputTypeVolumeFlow; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := v, float32(0.0); is != want {
t.Fatalf("is=%v want=%v", is, want)
}

outlets := OutletsFromValue(p.Outgoing)
assert.Equal(test, len(outlets), 13)
assert.False(test, outlets[0].Enabled)
assert.False(test, outlets[1].Enabled)
assert.False(test, outlets[2].Enabled)
assert.True(test, outlets[3].Enabled)
assert.True(test, outlets[4].Enabled)
assert.True(test, outlets[5].Enabled)
assert.True(test, outlets[6].Enabled)
assert.False(test, outlets[7].Enabled)
assert.False(test, outlets[8].Enabled)
assert.False(test, outlets[9].Enabled)
assert.False(test, outlets[10].Enabled)
assert.False(test, outlets[11].Enabled)
assert.False(test, outlets[12].Enabled)
if is, want := len(outlets), 13; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[0].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[1].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[2].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[3].Enabled, true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[4].Enabled, true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[5].Enabled, true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[6].Enabled, true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[7].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[8].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[9].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[10].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[11].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := outlets[12].Enabled, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}

h1, h2 := AreHeatMetersEnabled(p.HeatRegister)
assert.True(test, h1)
assert.False(test, h2)
if is, want := h1, true; is != want {
t.Fatalf("is=%v want=%v", is, want)
}
if is, want := h2, false; is != want {
t.Fatalf("is=%v want=%v", is, want)
}

}

0 comments on commit 66c9582

Please sign in to comment.