Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues playing on Safari / Safari Mobile #7

Closed
bryanbraun opened this issue Feb 8, 2020 · 2 comments
Closed

Issues playing on Safari / Safari Mobile #7

bryanbraun opened this issue Feb 8, 2020 · 2 comments
Projects

Comments

@bryanbraun
Copy link
Owner

We fixed this once by switching to requestAnimationFrame, but it looks like it's back.

This time, I suspect it's a cross-browser intersectionObserver issue, because I can still hear some notes when scrolling up quickly.

@bryanbraun bryanbraun created this issue from a note in Roadmap (To Do) Feb 8, 2020
@bryanbraun bryanbraun moved this from To Do to In Progress in Roadmap Jun 12, 2020
@bryanbraun
Copy link
Owner Author

It looks like we can solve a lot of tempo issues if we use the WebAudio clock instead of the Javascript/computer clock for scheduling notes. This is a decent refactor, but early tests show a dramatic improvement in all browsers, so we're doing it.

Reference docs: https://www.html5rocks.com/en/tutorials/audio/scheduling/#toc-usingsettimeout

@bryanbraun
Copy link
Owner Author

I just pushed up a rebuilt playing and scrolling system that fixes this issue in all the browsers I've been able to test. I'm really happy about it!

@bryanbraun bryanbraun moved this from In Progress to Done in Roadmap Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Done
Development

No branches or pull requests

1 participant