Skip to content

Bryan Smith
bryanrsmith

Organizations

@LogosBible @aurelia
@bryanrsmith
bryanrsmith merged pull request aurelia/fetch-client#37
@bryanrsmith
fix(http-client): handle last null param in fetch method
1 commit with 19 additions and 1 deletion
bryanrsmith commented on pull request aurelia/fetch-client#37
@bryanrsmith

Default parameters are only applied over undefined, and since the value is not validated from user code before this point I think it's a good change.…

bryanrsmith commented on pull request aurelia/fetch-client#37
@bryanrsmith

Thanks @vbauerster. LGTM. @EisenbergEffect please verify CLA.

@bryanrsmith
@bryanrsmith
  • @bryanrsmith 53a6eb3
    Fix: Handle singular case in rule-tester error message (fixes #5141)
@bryanrsmith
rule-tester should correctly pluralize error message
bryanrsmith opened pull request eslint/eslint#5140
@bryanrsmith
Fix: Handle singular case in rule-tester error message
1 commit with 5 additions and 5 deletions
@bryanrsmith
  • @bryanrsmith d7416de
    Fix: Handle singular case in rule-tester error message
@bryanrsmith
Better navigation failure logging
bryanrsmith commented on issue aurelia/router#282
@bryanrsmith

Closing for now. @cehoffman Please follow up if we've missed something.

bryanrsmith commented on pull request aurelia/router#286
@bryanrsmith

LGTM. @pato-p would you mind updating your commit message to follow our contributing guidelines? https://github.com/DurandalProject/about/blob/mast…

bryanrsmith commented on issue aurelia/router#284
@bryanrsmith

@EisenbergEffect Is there a good place to detect this error and log a helpful message instead of actually making the request for the empty module n…

@bryanrsmith
Null body status (204) is not handled correctly
@bryanrsmith

Cool, no problem. Response is part of the browser's fetch API, so in order to handle this we'd have to abstract that interface. We're hoping to avo…

@bryanrsmith
  • @bryanrsmith f001eba
    fix(http-client): ensure default content-type is respected
@bryanrsmith
withDefault headers Content-Type problem
@bryanrsmith

@cdennig I haven't been able to reproduce this. A PUT responding with a 204 is working as expected for me. Can you provide a more complete code sam…

bryanrsmith deleted branch ci-test at bryanrsmith/fetch-client
bryanrsmith deleted branch ci at bryanrsmith/fetch-client
@bryanrsmith

I should be able to look into this tonight. As far as I know this library never tries to read the response body, though. Do you have any response i…

bryanrsmith deleted branch update-karma at bryanrsmith/fetch-client
@bryanrsmith
bryanrsmith merged pull request aurelia/fetch-client#35
@bryanrsmith
chore(build): update karma
1 commit with 1 addition and 1 deletion
@bryanrsmith
bryanrsmith merged pull request aurelia/fetch-client#34
@bryanrsmith
pass original request as a second parameter to response/responseError
1 commit with 11 additions and 10 deletions
Something went wrong with that request. Please try again.