Bryan Smith bryanrsmith

Organizations

@LogosBible @aurelia
bryanrsmith opened pull request aurelia/fetch-client#6
@bryanrsmith
Fix crash in Firefox
2 commits with 93 additions and 24 deletions
@bryanrsmith
  • @bryanrsmith 15fbbbd
    feat(all): add type annotations
bryanrsmith commented on pull request aurelia/skeleton-navigation#123
@bryanrsmith

Both done. Will clean this up after the changes make it into a release.

bryanrsmith commented on pull request aurelia/router#171
@bryanrsmith

:+1:

bryanrsmith commented on pull request aurelia/fetch-client#5
@bryanrsmith

Rebased & ready to go, if @cmichaelgraham approves :-)

@bryanrsmith
  • @bryanrsmith c4542f9
    feat(all): add type annotations
@bryanrsmith
@bryanrsmith
@bryanrsmith
bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

@EisenbergEffect Looks good to me! Please verify CLA and merge at your convenience.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

:+1:

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

@alexanderchr I think it's fine. I just misread the code. Even though it doesn't direct manipulate the XHR, I agree that it's perfectly clear and a…

bryanrsmith opened pull request jspm/registry#500
@bryanrsmith
Add aurelia-fetch-client
1 commit with 1 addition and 0 deletions
@bryanrsmith
bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

@alexanderchr Ah, my mistake. I was looking at contentTransformer, which doesn't mutate the xhr. I think it's close enough, though :-)

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

No, I just mean a test that explicitly verifies the change you made to run request interceptors before the xhrTransformers. Something that would br…

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

Accidental fit? I see a couple minor formatting issues in this test too.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

Thanks, @alexanderchr! I think this has been bugging a lot of people. Would you mind making a couple cleanup changes? We update the dist/ files at…

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

Now that we have a base class, it might be nice to have it initialize its baseUrl property to the empty string, so things won't break if we fail to…

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

Same here.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

This test is now async & should use the done() callback.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

We should also verify that response interceptors are called before xhr transformers.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

This test will pass if the client fails to execute the interceptor. I think we could move this assertion into the .then continuation on line 812.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

I don't think this is right. It looks like this test will now pass if the promise resolves instead of rejects. We should verify that it doesn't res…

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

I think the old name of buildFullUrl is clearer because the verb clearly indicates what the method does.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

It'd be great to match the existing style, and leave the else on the same line as the previous closing brace.

bryanrsmith commented on pull request aurelia/http-client#74
@bryanrsmith

Should this be processor?