Bryan Smith bryanrsmith

Organizations

@LogosBible @aurelia
bryanrsmith commented on issue aurelia/router#139
@bryanrsmith

@EisenbergEffect We could probably solve the problem of configuring routers in singleton VMs by caching routers in a WeakMap. Should we consider wa…

@bryanrsmith
Navigating before the current route's activation has completed breaks rendering
bryanrsmith commented on issue aurelia/router#110
@bryanrsmith

Closing, as this appears to be an issue with the animator tracked in aurelia/framework#132.

bryanrsmith commented on issue aurelia/framework#158
@bryanrsmith

@EisenbergEffect That shouldn't be a problem, but I think we'd have to add a framework dependency on router. Will this cause problems in other plac…

bryanrsmith opened pull request aurelia/fetch-client#4
@bryanrsmith
Tests & eslint
4 commits with 376 additions and 26 deletions
bryanrsmith opened pull request eslint/eslint#2879
@bryanrsmith
Docs: Fix typo
1 commit with 1 addition and 1 deletion
@bryanrsmith
bryanrsmith commented on issue aurelia/router#134
@bryanrsmith

@ceoaliongroo I'm not sure I understand the problem. I can't seem to get any error to appear by using your sample app. Also, it looks like your das…

@bryanrsmith
Defaults can't be applied to externally-created Request objects
@bryanrsmith
  • @bryanrsmith 26aa9df
    feat(http-client-configuration): add chainable helpers for all config…
  • @bryanrsmith 0db0d10
    refactor(all): replaces uses of for..of to reduce compiled code size
  • 2 more commits »
bryanrsmith commented on pull request aurelia/router#135
@bryanrsmith

Sorry; I told @ceoaliongroo I'd try to write up some brief info on how viewports work to help with this, and I haven't got to it yet. I'll try to l…

bryanrsmith commented on issue aurelia/router#129
@bryanrsmith

Wouldn't you just need to add it again if the user logs out? Also, won't you want to redirect rather than showing an error on the login route? Inst…

@bryanrsmith
Parameter Routes and Navigation
bryanrsmith commented on issue aurelia/router#138
@bryanrsmith

If you specify nav: true on a route with dynamic segments you must provide an href to be used in the nav menu. { route: 'doc/:name', moduleId: './doc'

bryanrsmith commented on issue aurelia/router#136
@bryanrsmith

Sounds good to me! I think we can add this pretty trivially to app-router. Will we need to do anything to make sure we don't clobber any focus atte…

bryanrsmith deleted branch named-routes at bryanrsmith/skeleton-navigation
@bryanrsmith
Error in default route construction crashes chrome.
bryanrsmith commented on issue aurelia/router#137
@bryanrsmith

Thanks, @Zoltu. This was fixed by #130, which will be included in the next release.

bryanrsmith deleted branch paths at bryanrsmith/router
bryanrsmith deleted branch unknown-routes at bryanrsmith/router
bryanrsmith deleted branch nav-events at bryanrsmith/router
@bryanrsmith
Good practice advice request: is abstracting an httpClient request in a service class recommended?
bryanrsmith commented on issue aurelia/http-client#62
@bryanrsmith

Yes, I think that's a good approach. You can directly return the promise from send(), though. You don't need the wrapping promise. login(email, pas…

@bryanrsmith
Detect and avoid infinite redirects
bryanrsmith commented on pull request aurelia/router#127
@bryanrsmith

@EisenbergEffect Looks like it's up to date now.

bryanrsmith commented on pull request aurelia/router#127
@bryanrsmith

I'm not sure how I missed that while testing; sorry. Should be fixed now. I think I'm going to concentrate on increasing test coverage a bit before…