Various Fixes #8

Merged
merged 2 commits into from Jan 8, 2013

Conversation

Projects
None yet
4 participants

Atalanta commented Jan 6, 2013

Cloned your repo and ran vagrant up.

Various issues in the ark recipe and the default_tomcat template fixed.

Stephen Nelson-Smith added some commits Jan 6, 2013

Stephen Nelson-Smith
Fix: Various issues in ark recipe
- Directory resource needed
- Service name precalculated
- Update resource notification syntax
- Ordering of service
Stephen Nelson-Smith
Fix: Template / Hash Syntax Problems
- In several places, Hash values are attempted to be called using dot notation
  rather than strings, which cause breakages.  Changes to strings.
- When calculating whether the hash has a JMX password, use has_key

bryanwb added a commit that referenced this pull request Jan 8, 2013

Merge pull request #8 from Atalanta/master
Various Fixes

tks a lot SNS!

@bryanwb bryanwb merged commit 4acbe18 into bryanwb:master Jan 8, 2013

I think this breakes the tomcat lwrp which does:
variables(:tomcat => new_resource)
since new_resource is not a hash.

This commit also changes the usage of the jmx_opts. They were not previously added to JAVA_OPTS, and they should not be. This becomes a problem when the init.d tomcat script tries to 'stop' tomcat since JAVA_OPTS are used for that command. This then causes the issue described here: https://bowerstudios.com/node/636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment