Created duplicate when editing node details #36

Closed
leighghunt opened this Issue Jan 30, 2013 · 5 comments

Comments

Projects
None yet
2 participants

I updated a point of interest node's attributes. I then noticed that this created an entirely new node, rather than updating the existing node's details.

Interestingly, when I did the same a short while earlier against a different, everything worked as expected.

First (successful) changeset: http://www.openstreetmap.org/browse/changeset/14842472, node: http://www.openstreetmap.org/browse/node/1014181872/history

Second (unsuccessful) changeset: http://www.openstreetmap.org/browse/changeset/14842858, new duplicate node: http://www.openstreetmap.org/browse/node/2134410704/history - old original node (which I have now deleted): http://www.openstreetmap.org/browse/node/1501256105/history

Owner

bryceco commented Jan 30, 2013

I'd love to know the sequence you used to cause this. Were you using undo/redo, clearing the cache or anything else? Creating a node requires a specialized code path (it needs to have a negative identifier when being uploaded) and shouldn't happen by accident. Also if you can reproduce I'd like to know what the text says on the upload screen, specifically if the node is marked as Create or Modify.

Owner

bryceco commented Jan 30, 2013

I came up with one way to reproduce the symptoms of this:

  • Select an existing node.
  • Clear the cache: The pushpin remains displayed on top of the previous object, but the object is not actually selected.
  • Add tags to the pushpin, which creates a new object at that location. However, none of the preexisting tags would be inherited by the new object, you'd have to have entered all the tags again.

No, I didn't do any redo/undo, or clear the cache - I may have done a prepare for offline use before the 2nd edit, but I've since tried that again and it hasn't caused the issue. I've tried a number of different things, but haven't been able to reproduce the issue (http://www.openstreetmap.org/browse/node/482907485/history for description of my rather ad-hoc tests).

During the tests, I also discovered the issue you mentioned above, but came to the same conclusion, and I'm pretty sure I didn't re-enter the Type and Name values. Simply reselecting the object repopulates the tags when you edit the object, but this still doesn't cause the symptoms.

Weird - I'll keep an eye out for it over next few weeks to see if I run into it again, and update issue if I do.

Owner

bryceco commented Jul 25, 2014

Closed until we get a repro.

@bryceco bryceco closed this Jul 25, 2014

Owner

bryceco commented Aug 26, 2014

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment