Test framework for common interfaces #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycx
added
testing
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 96.18% 97.23% +1.04%
==========================================
Files 43 46 +3
Lines 6220 5708 -512
==========================================
- Hits 5983 5550 -433
+ Misses 237 158 -79
Continue to review full report at Codecov.
|
brycx
force-pushed
the
test-framework
branch
from
e977894
to
3a8bf8d
Compare
…at it used used both with quickcheck and in /tests
…t now that it used used both with quickcheck and in /tests
…ly on orion's testing framework having std as well.
brycx
changed the title
… on encrypt/decrypt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a lot of tests are repeated through multiple modules. For example, all implementations that offer incremental processing of data, such a hashing, use the same consistency-tests.
This PR suggests traits that are implemented by the interfaces that share common tests, and defines tests for these interfaces. Such that the actual test-cases only are implemented once. One drawback that has already come up is, that the generalisation makes it harder to develop
no_std-compatible tests. Though tests are not currently run in CI on ano_stdimage, the library is only built to check for compatibility.The motivation behind this is to reduce the amount of work required to review tests.
This should not be merged before #87 is finalised.