Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Footer type for JSON-encoded footers #52

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Add Footer type for JSON-encoded footers #52

merged 4 commits into from
Apr 26, 2022

Conversation

brycx
Copy link
Owner

@brycx brycx commented Apr 24, 2022

TODO:

  • Expand tests. Especially those regarding max_len/max_keys as well
  • Check error types of each method are okay. Some may still be leftover from Claims which Footer is a copy of
  • Add example of using this in the high-level API/docs
  • High-level API should take a Footer instance instead of Option<&[u8]>, but the lower-level APIs should still take the byte-slice. If lower-level API is used with Footer, the user can to_string().as_bytes()
  • Update changelog
  • Add fuzzer target (this can be combined with a fuzzer for Claims)

@brycx brycx merged commit 42f583a into v0.5.0 Apr 26, 2022
brycx added a commit that referenced this pull request Jun 4, 2022
* Add Footer

* Add fuzzer for Footer

* Expand testing of Footer

* Switch to TryFrom and add usage example
@brycx brycx deleted the typed-footer branch June 4, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant