Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for threejs v111 (A-Frame 1.0.1+) #9

Closed
kfarr opened this issue May 3, 2020 · 3 comments · Fixed by #10
Closed

Update for threejs v111 (A-Frame 1.0.1+) #9

kfarr opened this issue May 3, 2020 · 3 comments · Fixed by #10

Comments

@kfarr
Copy link

kfarr commented May 3, 2020

No longer works with more recent version of threejs. Same as this issue here:
https://stackoverflow.com/questions/59454931/three-js-r111-three-shaderlib-cube-uniforms-tcube-to-envmap-issue

A-Frame has rudimentary support for threejs scene background:

The core A-Frame background scene component could be improved, or this custom component could be updated to support newer versions of threejs:

@bryik
Copy link
Owner

bryik commented May 3, 2020

I'll look into updating this component.

@bryik bryik linked a pull request May 3, 2020 that will close this issue
@bryik
Copy link
Owner

bryik commented May 3, 2020

@kfarr any thoughts on this MR? If it looks good, I'll merge it and publish v1.0.0 to NPM. Feels like a major version increment is necessary as this change will not be backwards compatible.

@kfarr
Copy link
Author

kfarr commented May 3, 2020

@bryik I just tried the updated code on my project and it seems to work! And the number of triangles is greatly reduced using the cubemap instead of the skybox! :) Agreed this is a breaking change for old aframe versions so new version number makes sense.

@bryik bryik closed this as completed in #10 May 3, 2020
bryik added a commit that referenced this issue May 3, 2020
Fix for latest version of A-Frame (closes #9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants