Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

toolbar is not inserted because 304 is not "ok?" #30

ghazel opened this Issue Dec 1, 2010 · 1 comment


None yet
1 participant

ghazel commented Dec 1, 2010

When I click the bookmarklet and type my password, the toolbar does not appear. Hard-refreshing the page makes the toolbar appear.

Digging in to the source, I see that @response.ok? returns false, because the status code is 304 (Not Modified) instead of 200. One way around this I used was to strip "HTTP_IF_NONE_MATCH" from the env before passing on the request, so the etag would not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment