Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix 'explain' and 'select' view for Postgresql and make backtrace info sortable #35

Merged
merged 2 commits into from Oct 13, 2011

Conversation

Projects
None yet
2 participants
Contributor

consti commented May 31, 2011

  • Fix for Postgres:
    • result.fetch_fields does not work if using postgres as a database.
    • Similar to Mysql2, we have to use result.fields (if defined?(PGresult)).
  • CSS and JS cleanup:
    • move 'explain', 'backtrace' etc. links to the left
    • also switch to CSS nth-element instead of odd/even classes.
    • move backtrace info out of own into a div within the corresponding (that makes it sort stable.)

consti added some commits May 31, 2011

Add compatibility for Postgres
Check if PGresult is defined, use result.fields
instead of result.fetch_fields in views.
move 'explain', 'backtrace' etc. links to the left
- also switch to CSS nth-element instead of odd/
even classes.

- move backtrace info out of own <tr/> into a
div within the corresponding <td/> (that makes it
sort stable.

knzconnor added a commit that referenced this pull request Oct 13, 2011

Merge pull request #35 from tupalo/master
Fix 'explain' and 'select' view for Postgresql and make backtrace info sortable

@knzconnor knzconnor merged commit 7b866bf into brynary:master Oct 13, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment