Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week start day and number are not updated on locale change #1421

Closed
bmblb opened this issue Aug 28, 2020 · 0 comments
Closed

Week start day and number are not updated on locale change #1421

bmblb opened this issue Aug 28, 2020 · 0 comments
Assignees
@ExtAnimal
Labels
bug Something isn't working localization resolved Fixed but not yet released (available in the nightly builds)
Milestone
4.0.6

Comments

@bmblb
Copy link

bmblb commented Aug 28, 2020

Week start day and week number are locked to the initial values and are not updated on locale change. To reproduce on basic demo:

  1. open example in english locale, see week starts on sunday (see calendar widget and header)
    image
  2. switch locale to Svenska (see widget on the left is updated, but header still shows sunday as week start)
    image
  3. refresh page (see week start is correct in header too now)
    image

To see problem with week number, click on saturday and sunday. In step 2 those will have different week numbers, but for swedish locale they should be in one week.
@bmblb bmblb added bug Something isn't working localization labels Aug 28, 2020
@isglass isglass added this to the Calendar 4.0.1 milestone Aug 28, 2020
@matsbryntse matsbryntse modified the milestones: Calendar 4.0.1, Calendar 4.0.2 Nov 3, 2020
@isglass isglass modified the milestones: Calendar 4.0.2, Calendar 4.0.3 Nov 6, 2020
@isglass isglass modified the milestones: Calendar 4.0.3, 4.0.4 Nov 18, 2020
@isglass isglass modified the milestones: 4.0.4, 4.0.5 Dec 9, 2020
@ExtAnimal ExtAnimal self-assigned this Dec 15, 2020
@matsbryntse matsbryntse modified the milestones: 4.0.5, 4.0.6 Dec 16, 2020
@ExtAnimal ExtAnimal added the resolved Fixed but not yet released (available in the nightly builds) label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ExtAnimal ExtAnimal

Labels
bug Something isn't working localization resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Milestone
4.0.6
Development

No branches or pull requests
4 participants
@ExtAnimal @matsbryntse @isglass @bmblb