Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icon Intraday events in Month and Agenda view #3409

Closed
javascript-programming opened this issue Sep 13, 2021 · 9 comments
Closed

Missing icon Intraday events in Month and Agenda view #3409

javascript-programming opened this issue Sep 13, 2021 · 9 comments
Assignees
Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@javascript-programming
Copy link

http://lh/calendar-4.2.5/examples/shifted/

Screenshot 2021-09-13 at 17 09 09

Should look like this

Screenshot 2021-09-13 at 16 49 14

@isglass isglass added this to the 4.3.0 milestone Sep 13, 2021
@isglass isglass added bug Something isn't working high-priority Urgent to have fixed labels Sep 13, 2021
@ExtAnimal
Copy link

@javascript-programming
Copy link
Author

calendar 4.2.2 is still correct it got broken in 4.2.3

@dongryphon dongryphon self-assigned this Sep 14, 2021
@dongryphon
Copy link

The data for the "Should be this" image looks completely different than the data for that example... is this a modified example to illustrate the issue? If so, can you attach the revised example here?

Also, is this only observed in the shifted day example or do others (like the basic example) have the problem as well?

@dongryphon
Copy link

Are we just talking about the red and green icons and not the events/data?

@javascript-programming
Copy link
Author

Screenshot 2021-09-14 at 14 48 58

See the 4.2.2 it got broken from there

@javascript-programming
Copy link
Author

javascript-programming commented Sep 14, 2021

Also in the basic example

4.2.2
Screenshot 2021-09-14 at 14 51 55

4.2.5
Screenshot 2021-09-14 at 14 52 47

@javascript-programming
Copy link
Author

icon class does not seem to be added to intraday events

@javascript-programming
Copy link
Author

eventColor is set on the icon and with icon missing we have no color display anymore

@dongryphon dongryphon added ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Sep 14, 2021
@isglass isglass modified the milestones: 4.3.0, 4.2.6 Sep 14, 2021
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Sep 14, 2021
@ExtAnimal ExtAnimal removed the resolved Fixed but not yet released (available in the nightly builds) label Sep 15, 2021
@ExtAnimal
Copy link

Reopened. The icons are still display:none for allDay events. They show up for intraday events, but are explicitly hidden for allDay events. I don't think this is right.

icons-display-none.mp4

@isglass isglass added the resolved Fixed but not yet released (available in the nightly builds) label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority Urgent to have fixed resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants