Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlightTimeSpan function throwing error when taskStore is filtered #4590

Closed
taauntik opened this issue May 11, 2022 · 0 comments
Closed

highlightTimeSpan function throwing error when taskStore is filtered #4590

taauntik opened this issue May 11, 2022 · 0 comments
Assignees
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@taauntik
Copy link

Forum post

Hello!

Here's how to reproduce:

Load the demo: https://bryntum.com/examples/gantt/highlight-time-spans/
In the console, apply a filter:

gantt.taskStore.filter({filters : task => task.name == "xx", replace : true});

Then create a highlight for a task:

gantt.highlightTimeSpan({
    taskRecord: gantt.project.taskStore.getById(1),
    name      : 'hello!',
    startDate : new Date(2019, 01, 01),
    endDate   : new Date(2019, 01, 06)
})

Crash!

image

Expected:
I'd expect highlightTimeSpan() to do nothing
If it did nothing and I then I had the task shown by changing the filter, I'd expect the highlighted timespan to be visible again.

Also, if you highlight a task timespan and THEN apply a filter so that task moves around, the timespan does not follow its task.

@taauntik taauntik added bug Something isn't working forum Issues from forum labels May 11, 2022
@matsbryntse matsbryntse changed the title highlightTimeSpan function throwing error highlightTimeSpan function throwing error when taskStore is filtered May 11, 2022
@isglass isglass added this to the 5.x.x milestone May 11, 2022
@matsbryntse matsbryntse added the ready for review Issue is fixed, the pull request is being reviewed label May 11, 2022
@matsbryntse matsbryntse self-assigned this May 11, 2022
@matsbryntse matsbryntse modified the milestones: 5.x.x, 5.0.5 May 11, 2022
@matsbryntse matsbryntse added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants