Save and load options using cookies #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsoyka
reviewed
Oct 5, 2019
| var select_second = document.getElementById("second-select"); | ||
| select_first.value = getCookie("first-select"); | ||
| select_second.value = getCookie("second-select"); | ||
| run(); |
Owner
There was a problem hiding this comment.
Probably a silly question, but may I ask why this run(); line is here?
Contributor
Author
There was a problem hiding this comment.
The run(); line is to generate the Mystery Egg again after loading the cookied options.
Contributor
Author
There was a problem hiding this comment.
I noticed that the Randomize button is calling run() function, and I wanted to regenerate or randomize the mystery egg after loading the cookies.
bsoyka
approved these changes
Oct 5, 2019
Owner
bsoyka
left a comment
bsoyka
left a comment
There was a problem hiding this comment.
Looks great, thanks for your help!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save and load options using cookies
onloadattributes to each of theselecttags.setCookie- function that takes name, value and number of days until the cookie expires and sets a cookie with those parameters.getCookie- function which returns the cookie value given the name.saveOptionsAsCookie- function to set a cookie with the element's id as name and element's value as value.getOptionsFromCookies- function to get the saved options from the cookies and set them. It also calls therun()function to regenerate the mystery egg